Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6029)

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/downloads/downloads_api.cc
diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc
index 47f7fa50445bfe537763062874ef2db1f6842439..84e184241feb522b78641491b08839f0913d2ecc 100644
--- a/chrome/browser/extensions/api/downloads/downloads_api.cc
+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc
@@ -297,12 +297,13 @@ class DownloadFileIconExtractorImpl : public DownloadFileIconExtractor {
public:
DownloadFileIconExtractorImpl() {}
- virtual ~DownloadFileIconExtractorImpl() {}
+ ~DownloadFileIconExtractorImpl() override {}
+
+ bool ExtractIconURLForPath(const base::FilePath& path,
+ float scale,
+ IconLoader::IconSize icon_size,
+ IconURLCallback callback) override;
- virtual bool ExtractIconURLForPath(const base::FilePath& path,
- float scale,
- IconLoader::IconSize icon_size,
- IconURLCallback callback) override;
private:
void OnIconLoadComplete(
float scale, const IconURLCallback& callback, gfx::Image* icon);
@@ -599,7 +600,7 @@ class ExtensionDownloadsEventRouterData : public base::SupportsUserData::Data {
download_item->SetUserData(kKey, this);
}
- virtual ~ExtensionDownloadsEventRouterData() {
+ ~ExtensionDownloadsEventRouterData() override {
if (updated_ > 0) {
UMA_HISTOGRAM_PERCENTAGE("Download.OnChanged",
(changed_fired_ * 100 / updated_));
@@ -889,11 +890,9 @@ class ManagerDestructionObserver : public DownloadManager::Observer {
manager_->AddObserver(this);
}
- virtual ~ManagerDestructionObserver() {
- manager_->RemoveObserver(this);
- }
+ ~ManagerDestructionObserver() override { manager_->RemoveObserver(this); }
- virtual void ManagerGoingDown(DownloadManager* manager) override {
+ void ManagerGoingDown(DownloadManager* manager) override {
manager_file_existence_last_checked_->erase(manager);
if (manager_file_existence_last_checked_->size() == 0) {
delete manager_file_existence_last_checked_;

Powered by Google App Engine
This is Rietveld 408576698