Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/browser/extensions/startup_helper.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/startup_helper.h ('k') | chrome/browser/extensions/startup_helper_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/startup_helper.cc
diff --git a/chrome/browser/extensions/startup_helper.cc b/chrome/browser/extensions/startup_helper.cc
index e9b33cbf646cc9cf07d53b49cce50ec197f8ecf1..b90fed3cd9b87896a376fea0c4f63ce76ab8a954 100644
--- a/chrome/browser/extensions/startup_helper.cc
+++ b/chrome/browser/extensions/startup_helper.cc
@@ -138,13 +138,13 @@ class ValidateCrxHelper : public SandboxedUnpackerClient {
}
protected:
- virtual ~ValidateCrxHelper() {}
+ ~ValidateCrxHelper() override {}
- virtual void OnUnpackSuccess(const base::FilePath& temp_dir,
- const base::FilePath& extension_root,
- const base::DictionaryValue* original_manifest,
- const Extension* extension,
- const SkBitmap& install_icon) override {
+ void OnUnpackSuccess(const base::FilePath& temp_dir,
+ const base::FilePath& extension_root,
+ const base::DictionaryValue* original_manifest,
+ const Extension* extension,
+ const SkBitmap& install_icon) override {
finished_ = true;
success_ = true;
BrowserThread::PostTask(BrowserThread::UI,
@@ -153,7 +153,7 @@ class ValidateCrxHelper : public SandboxedUnpackerClient {
this));
}
- virtual void OnUnpackFailure(const base::string16& error) override {
+ void OnUnpackFailure(const base::string16& error) override {
finished_ = true;
success_ = false;
error_ = error;
« no previous file with comments | « chrome/browser/extensions/startup_helper.h ('k') | chrome/browser/extensions/startup_helper_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698