chrome/browser/extensions/api/developer_private/entry_picker.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/entry_picker.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_api.h ('k') | chrome/browser/extensions/api/dial/dial_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/entry_picker.h

diff --git a/chrome/browser/extensions/api/developer_private/entry_picker.h b/chrome/browser/extensions/api/developer_private/entry_picker.h

index b5afbde5e18351eae6f3dd12e0e8d23006a408c1..5fafbc6407af774c5436012554d82cfb5571a21c 100644

--- a/chrome/browser/extensions/api/developer_private/entry_picker.h

+++ b/chrome/browser/extensions/api/developer_private/entry_picker.h

@@ -39,15 +39,15 @@ class EntryPicker : public ui::SelectFileDialog::Listener {

static void StopSkippingPickerForTest();

protected:

- virtual ~EntryPicker();

+ ~EntryPicker() override;

private:

// ui::SelectFileDialog::Listener implementation.

- virtual void FileSelected(const base::FilePath& path,

- int index,

- void* params) override;

+ void FileSelected(const base::FilePath& path,

+ int index,

+ void* params) override;

- virtual void FileSelectionCanceled(void* params) override;

+ void FileSelectionCanceled(void* params) override;

scoped_refptr<ui::SelectFileDialog> select_file_dialog_;

EntryPickerClient* client_;