chrome/browser/extensions/extension_notification_observer.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_notification_observer.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_messages_apitest.cc ('k') | chrome/browser/extensions/extension_prefs_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_notification_observer.h

diff --git a/chrome/browser/extensions/extension_notification_observer.h b/chrome/browser/extensions/extension_notification_observer.h

index cfd8dd9c1c7c3bd282759ed53759fdd7bf9bb015..3d46ccfc359491176c9de5748f135cab6a2bcc3e 100644

--- a/chrome/browser/extensions/extension_notification_observer.h

+++ b/chrome/browser/extensions/extension_notification_observer.h

@@ -26,7 +26,7 @@ class ExtensionNotificationObserver : public content::NotificationObserver {

ExtensionNotificationObserver(content::NotificationSource source,

const std::set<std::string>& extension_ids);

- virtual ~ExtensionNotificationObserver();

+ ~ExtensionNotificationObserver() override;

// Each of these methods returns a testing::AssertionSuccess if exactly those

// notifications occurred for any extensions in |extension_ids|, and no more,

@@ -51,9 +51,9 @@ class ExtensionNotificationObserver : public content::NotificationObserver {

private:

// content::NotificationObserver implementation.

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

// Checks then clears notifications for our extensions.

testing::AssertionResult CheckNotifications(

« no previous file with comments | « chrome/browser/extensions/extension_messages_apitest.cc ('k') | chrome/browser/extensions/extension_prefs_unittest.cc » ('j') | no next file with comments »