chrome/browser/extensions/api/mdns/mdns_api.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/mdns/mdns_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/mdns/dns_sd_registry_unittest.cc ('k') | chrome/browser/extensions/api/mdns/mdns_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/mdns/mdns_api.h

diff --git a/chrome/browser/extensions/api/mdns/mdns_api.h b/chrome/browser/extensions/api/mdns/mdns_api.h

index e659b0a999be0ed8828cd76fdff89e3d4d8dd1a5..f232d3b07b95432a04137b46d5e01da57ec901cf 100644

--- a/chrome/browser/extensions/api/mdns/mdns_api.h

+++ b/chrome/browser/extensions/api/mdns/mdns_api.h

@@ -31,7 +31,7 @@ class MDnsAPI : public BrowserContextKeyedAPI,

public DnsSdRegistry::DnsSdObserver {

public:

explicit MDnsAPI(content::BrowserContext* context);

- virtual ~MDnsAPI();

+ ~MDnsAPI() override;

static MDnsAPI* Get(content::BrowserContext* context);

@@ -49,13 +49,12 @@ class MDnsAPI : public BrowserContextKeyedAPI,

friend class BrowserContextKeyedAPIFactory<MDnsAPI>;

// EventRouter::Observer:

- virtual void OnListenerAdded(const EventListenerInfo& details) override;

- virtual void OnListenerRemoved(const EventListenerInfo& details) override;

+ void OnListenerAdded(const EventListenerInfo& details) override;

+ void OnListenerRemoved(const EventListenerInfo& details) override;

// DnsSdRegistry::Observer

- virtual void OnDnsSdEvent(

- const std::string& service_type,

- const DnsSdRegistry::DnsSdServiceList& services) override;

+ void OnDnsSdEvent(const std::string& service_type,

+ const DnsSdRegistry::DnsSdServiceList& services) override;

// BrowserContextKeyedAPI implementation.

static const char* service_name() {