chrome/browser/extensions/api/image_writer_private/image_writer_private_api.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/image_writer_private_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation.h ('k') | chrome/browser/extensions/api/image_writer_private/image_writer_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/image_writer_private/image_writer_private_api.h

diff --git a/chrome/browser/extensions/api/image_writer_private/image_writer_private_api.h b/chrome/browser/extensions/api/image_writer_private/image_writer_private_api.h

index e55150cf55d51a6cf92eb5339a496942e3346be2..a7abf444f33968d520bbaa87e83472f7198dac86 100644

--- a/chrome/browser/extensions/api/image_writer_private/image_writer_private_api.h

+++ b/chrome/browser/extensions/api/image_writer_private/image_writer_private_api.h

@@ -18,8 +18,8 @@ class ImageWriterPrivateWriteFromUrlFunction

ImageWriterPrivateWriteFromUrlFunction();

private:

- virtual ~ImageWriterPrivateWriteFromUrlFunction();

- virtual bool RunAsync() override;

+ ~ImageWriterPrivateWriteFromUrlFunction() override;

+ bool RunAsync() override;

void OnWriteStarted(bool success, const std::string& error);

};

@@ -31,8 +31,8 @@ class ImageWriterPrivateWriteFromFileFunction

ImageWriterPrivateWriteFromFileFunction();

private:

- virtual ~ImageWriterPrivateWriteFromFileFunction();

- virtual bool RunAsync() override;

+ ~ImageWriterPrivateWriteFromFileFunction() override;

+ bool RunAsync() override;

void OnWriteStarted(bool success, const std::string& error);

};

@@ -44,8 +44,8 @@ class ImageWriterPrivateCancelWriteFunction

ImageWriterPrivateCancelWriteFunction();

private:

- virtual ~ImageWriterPrivateCancelWriteFunction();

- virtual bool RunAsync() override;

+ ~ImageWriterPrivateCancelWriteFunction() override;

+ bool RunAsync() override;

void OnWriteCancelled(bool success, const std::string& error);

};

@@ -57,8 +57,8 @@ class ImageWriterPrivateDestroyPartitionsFunction

ImageWriterPrivateDestroyPartitionsFunction();

private:

- virtual ~ImageWriterPrivateDestroyPartitionsFunction();

- virtual bool RunAsync() override;

+ ~ImageWriterPrivateDestroyPartitionsFunction() override;

+ bool RunAsync() override;

void OnDestroyComplete(bool success, const std::string& error);

};

@@ -70,8 +70,8 @@ class ImageWriterPrivateListRemovableStorageDevicesFunction

ImageWriterPrivateListRemovableStorageDevicesFunction();

private:

- virtual ~ImageWriterPrivateListRemovableStorageDevicesFunction();

- virtual bool RunAsync() override;

+ ~ImageWriterPrivateListRemovableStorageDevicesFunction() override;

+ bool RunAsync() override;

void OnDeviceListReady(scoped_refptr<StorageDeviceList> device_list,

bool success);

};