chrome/browser/extensions/api/image_writer_private/operation_unittest.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/operation_unittest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc ('k') | chrome/browser/extensions/api/image_writer_private/test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/image_writer_private/operation_unittest.cc

diff --git a/chrome/browser/extensions/api/image_writer_private/operation_unittest.cc b/chrome/browser/extensions/api/image_writer_private/operation_unittest.cc

index e2932365c999f0ed9c7125a993e1cb886905c5dc..4ec4290d4d699d221dbe525cd4b4a21dae22a7df 100644

--- a/chrome/browser/extensions/api/image_writer_private/operation_unittest.cc

+++ b/chrome/browser/extensions/api/image_writer_private/operation_unittest.cc

@@ -37,7 +37,7 @@ class OperationForTest : public Operation {

const std::string& device_path)

: Operation(manager_, extension_id, device_path) {}

- virtual void StartImpl() override {}

+ void StartImpl() override {}

// Expose internal stages for testing.

void Unzip(const base::Closure& continuation) {

@@ -60,7 +60,7 @@ class OperationForTest : public Operation {

base::FilePath GetImagePath() { return image_path_; }

private:

- virtual ~OperationForTest() {};

+ ~OperationForTest() override{};

};

class ImageWriterOperationTest : public ImageWriterUnitTestBase {