chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_crypto_delegate_stub.cc ('k') | chrome/browser/extensions/api/extension_action/extension_action_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api.h

diff --git a/chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api.h b/chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api.h

index a512763bfe8dadd47674c45a7f4fcb7c4134e397..e199f2887047263868545a383e65f8680bfdcacb 100644

--- a/chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api.h

+++ b/chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api.h

@@ -12,10 +12,10 @@ namespace extensions {

class ExperienceSamplingPrivateGetBrowserInfoFunction

: public ChromeAsyncExtensionFunction {

protected:

- virtual ~ExperienceSamplingPrivateGetBrowserInfoFunction() {}

+ ~ExperienceSamplingPrivateGetBrowserInfoFunction() override {}

// ExtensionFuction:

- virtual bool RunAsync() override;

+ bool RunAsync() override;

private:

DECLARE_EXTENSION_FUNCTION("experienceSamplingPrivate.getBrowserInfo",