chrome/browser/extensions/chrome_extension_web_contents_observer.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_extension_web_contents_observer.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/chrome_extension_host_delegate.h ('k') | chrome/browser/extensions/chrome_extensions_browser_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/chrome_extension_web_contents_observer.h

diff --git a/chrome/browser/extensions/chrome_extension_web_contents_observer.h b/chrome/browser/extensions/chrome_extension_web_contents_observer.h

index b11ba2492d75b15e559ea4231eb9c1492ed13c2a..e50119984f276013694c2a0775832242b3d10d18 100644

--- a/chrome/browser/extensions/chrome_extension_web_contents_observer.h

+++ b/chrome/browser/extensions/chrome_extension_web_contents_observer.h

@@ -28,14 +28,12 @@ class ChromeExtensionWebContentsObserver

explicit ChromeExtensionWebContentsObserver(

content::WebContents* web_contents);

- virtual ~ChromeExtensionWebContentsObserver();

+ ~ChromeExtensionWebContentsObserver() override;

// content::WebContentsObserver overrides.

- virtual void RenderViewCreated(content::RenderViewHost* render_view_host)

- override;

- virtual bool OnMessageReceived(

- const IPC::Message& message,

- content::RenderFrameHost* render_frame_host) override;

+ void RenderViewCreated(content::RenderViewHost* render_view_host) override;

+ bool OnMessageReceived(const IPC::Message& message,

+ content::RenderFrameHost* render_frame_host) override;

// Adds a message to the extensions ErrorConsole.

void OnDetailedConsoleMessageAdded(const base::string16& message,