chrome/browser/extensions/browser_extension_window_controller.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/browser_extension_window_controller.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/bookmark_app_helper_unittest.cc ('k') | chrome/browser/extensions/browser_permissions_policy_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/browser_extension_window_controller.h

diff --git a/chrome/browser/extensions/browser_extension_window_controller.h b/chrome/browser/extensions/browser_extension_window_controller.h

index 7899edcd1d971dc9a875f878a1cb418f367d10ff..24384caf500879c32c85d5c6c88224eb61c52f63 100644

--- a/chrome/browser/extensions/browser_extension_window_controller.h

+++ b/chrome/browser/extensions/browser_extension_window_controller.h

@@ -16,21 +16,21 @@ class Extension;

class BrowserExtensionWindowController : public extensions::WindowController {

public:

explicit BrowserExtensionWindowController(Browser* browser);

- virtual ~BrowserExtensionWindowController();

+ ~BrowserExtensionWindowController() override;

// extensions::WindowController implementation.

- virtual int GetWindowId() const override;

- virtual std::string GetWindowTypeText() const override;

- virtual base::DictionaryValue* CreateWindowValue() const override;

- virtual base::DictionaryValue* CreateWindowValueWithTabs(

+ int GetWindowId() const override;

+ std::string GetWindowTypeText() const override;

+ base::DictionaryValue* CreateWindowValue() const override;

+ base::DictionaryValue* CreateWindowValueWithTabs(

const extensions::Extension* extension) const override;

- virtual base::DictionaryValue* CreateTabValue(

- const extensions::Extension* extension, int tab_index) const override;

- virtual bool CanClose(Reason* reason) const override;

- virtual void SetFullscreenMode(bool is_fullscreen,

- const GURL& extension_url) const override;

- virtual Browser* GetBrowser() const override;

- virtual bool IsVisibleToExtension(

+ base::DictionaryValue* CreateTabValue(const extensions::Extension* extension,

+ int tab_index) const override;

+ bool CanClose(Reason* reason) const override;

+ void SetFullscreenMode(bool is_fullscreen,

+ const GURL& extension_url) const override;

+ Browser* GetBrowser() const override;

+ bool IsVisibleToExtension(

const extensions::Extension* extension) const override;

private: