Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: chrome/browser/extensions/extension_resource_protocols.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_resource_protocols.cc
diff --git a/chrome/browser/extensions/extension_resource_protocols.cc b/chrome/browser/extensions/extension_resource_protocols.cc
index f719adb3b40bb4b91494af08063a839f8129bd36..92c8b2129150e5e11a25680d99d5abd64467899f 100644
--- a/chrome/browser/extensions/extension_resource_protocols.cc
+++ b/chrome/browser/extensions/extension_resource_protocols.cc
@@ -33,13 +33,12 @@ class ExtensionResourcesJob : public net::URLRequestFileJob {
base::SequencedWorkerPool::SKIP_ON_SHUTDOWN)),
weak_ptr_factory_(this) {}
- virtual void Start() override;
+ void Start() override;
- virtual bool IsRedirectResponse(GURL* location,
- int* http_status_code) override;
+ bool IsRedirectResponse(GURL* location, int* http_status_code) override;
protected:
- virtual ~ExtensionResourcesJob() {}
+ ~ExtensionResourcesJob() override {}
void ResolvePathDone(const base::FilePath& resolved_path);
@@ -76,9 +75,9 @@ class ExtensionResourceProtocolHandler
: public net::URLRequestJobFactory::ProtocolHandler {
public:
ExtensionResourceProtocolHandler() {}
- virtual ~ExtensionResourceProtocolHandler() {}
+ ~ExtensionResourceProtocolHandler() override {}
- virtual net::URLRequestJob* MaybeCreateJob(
+ net::URLRequestJob* MaybeCreateJob(
net::URLRequest* request,
net::NetworkDelegate* network_delegate) const override;

Powered by Google App Engine
This is Rietveld 408576698