Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1810)

Unified Diff: chrome/browser/extensions/extension_disabled_ui.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_disabled_ui.cc
diff --git a/chrome/browser/extensions/extension_disabled_ui.cc b/chrome/browser/extensions/extension_disabled_ui.cc
index ebdf6dfec40b383800a301fd88b5e0f7b717e9d7..5b1e197c275329aa076559c463a4edbc716ab7d0 100644
--- a/chrome/browser/extensions/extension_disabled_ui.cc
+++ b/chrome/browser/extensions/extension_disabled_ui.cc
@@ -96,11 +96,11 @@ class ExtensionDisabledDialogDelegate
private:
friend class base::RefCountedThreadSafe<ExtensionDisabledDialogDelegate>;
- virtual ~ExtensionDisabledDialogDelegate();
+ ~ExtensionDisabledDialogDelegate() override;
// ExtensionInstallPrompt::Delegate:
- virtual void InstallUIProceed() override;
- virtual void InstallUIAbort(bool user_initiated) override;
+ void InstallUIProceed() override;
+ void InstallUIAbort(bool user_initiated) override;
// The UI for showing the install dialog when enabling.
scoped_ptr<ExtensionInstallPrompt> install_ui_;
@@ -150,32 +150,32 @@ class ExtensionDisabledGlobalError
const Extension* extension,
bool is_remote_install,
const gfx::Image& icon);
- virtual ~ExtensionDisabledGlobalError();
+ ~ExtensionDisabledGlobalError() override;
// GlobalError implementation.
- virtual Severity GetSeverity() override;
- virtual bool HasMenuItem() override;
- virtual int MenuItemCommandID() override;
- virtual base::string16 MenuItemLabel() override;
- virtual void ExecuteMenuItem(Browser* browser) override;
- virtual gfx::Image GetBubbleViewIcon() override;
- virtual base::string16 GetBubbleViewTitle() override;
- virtual std::vector<base::string16> GetBubbleViewMessages() override;
- virtual base::string16 GetBubbleViewAcceptButtonLabel() override;
- virtual base::string16 GetBubbleViewCancelButtonLabel() override;
- virtual void OnBubbleViewDidClose(Browser* browser) override;
- virtual void BubbleViewAcceptButtonPressed(Browser* browser) override;
- virtual void BubbleViewCancelButtonPressed(Browser* browser) override;
- virtual bool ShouldCloseOnDeactivate() const override;
+ Severity GetSeverity() override;
+ bool HasMenuItem() override;
+ int MenuItemCommandID() override;
+ base::string16 MenuItemLabel() override;
+ void ExecuteMenuItem(Browser* browser) override;
+ gfx::Image GetBubbleViewIcon() override;
+ base::string16 GetBubbleViewTitle() override;
+ std::vector<base::string16> GetBubbleViewMessages() override;
+ base::string16 GetBubbleViewAcceptButtonLabel() override;
+ base::string16 GetBubbleViewCancelButtonLabel() override;
+ void OnBubbleViewDidClose(Browser* browser) override;
+ void BubbleViewAcceptButtonPressed(Browser* browser) override;
+ void BubbleViewCancelButtonPressed(Browser* browser) override;
+ bool ShouldCloseOnDeactivate() const override;
// ExtensionUninstallDialog::Delegate implementation.
- virtual void ExtensionUninstallAccepted() override;
- virtual void ExtensionUninstallCanceled() override;
+ void ExtensionUninstallAccepted() override;
+ void ExtensionUninstallCanceled() override;
// content::NotificationObserver implementation.
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override;
private:
ExtensionService* service_;

Powered by Google App Engine
This is Rietveld 408576698