chrome/browser/extensions/sandboxed_unpacker.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/sandboxed_unpacker.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/proxy_overridden_bubble_controller.cc ('k') | chrome/browser/extensions/sandboxed_unpacker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/sandboxed_unpacker.h

diff --git a/chrome/browser/extensions/sandboxed_unpacker.h b/chrome/browser/extensions/sandboxed_unpacker.h

index 323b4c65e825f8eab4242891406e7f404cd2f801..60a5bbdd4aa0b517857e283c22c11b4bcc92bb2a 100644

--- a/chrome/browser/extensions/sandboxed_unpacker.h

+++ b/chrome/browser/extensions/sandboxed_unpacker.h

@@ -154,7 +154,7 @@ class SandboxedUnpacker : public content::UtilityProcessHostClient {

friend class ProcessHostClient;

friend class SandboxedUnpackerTest;

- virtual ~SandboxedUnpacker();

+ ~SandboxedUnpacker() override;

// Set |temp_dir_| as a temporary directory to unpack the extension in.

// Return true on success.

@@ -175,8 +175,8 @@ class SandboxedUnpacker : public content::UtilityProcessHostClient {

void StartProcessOnIOThread(const base::FilePath& temp_crx_path);

// UtilityProcessHostClient

- virtual bool OnMessageReceived(const IPC::Message& message) override;

- virtual void OnProcessCrashed(int exit_code) override;

+ bool OnMessageReceived(const IPC::Message& message) override;

+ void OnProcessCrashed(int exit_code) override;

// IPC message handlers.

void OnUnpackExtensionSucceeded(const base::DictionaryValue& manifest);