Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc
diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc
index 0074b7042e353e93855fc24ea16077f565fc13ce..a462e58d2eb950cc84e9749aa527c84d6a802e1e 100644
--- a/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc
+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc
@@ -45,7 +45,7 @@ class WebstoreInstallListener : public WebstoreInstaller::Delegate {
WebstoreInstallListener()
: received_failure_(false), received_success_(false), waiting_(false) {}
- virtual void OnExtensionInstallSuccess(const std::string& id) override {
+ void OnExtensionInstallSuccess(const std::string& id) override {
received_success_ = true;
id_ = id;
@@ -55,7 +55,7 @@ class WebstoreInstallListener : public WebstoreInstaller::Delegate {
}
}
- virtual void OnExtensionInstallFailure(
+ void OnExtensionInstallFailure(
const std::string& id,
const std::string& error,
WebstoreInstaller::FailureReason reason) override {
@@ -95,14 +95,14 @@ class ExtensionWebstorePrivateApiTest : public ExtensionApiTest {
ExtensionWebstorePrivateApiTest() {}
virtual ~ExtensionWebstorePrivateApiTest() {}
- virtual void SetUpCommandLine(CommandLine* command_line) override {
+ void SetUpCommandLine(CommandLine* command_line) override {
ExtensionApiTest::SetUpCommandLine(command_line);
command_line->AppendSwitchASCII(
switches::kAppsGalleryURL,
"http://www.example.com/files/extensions/api_test");
}
- virtual void SetUpInProcessBrowserTestFixture() override {
+ void SetUpInProcessBrowserTestFixture() override {
ExtensionApiTest::SetUpInProcessBrowserTestFixture();
// Start up the test server and get us ready for calling the install
@@ -112,7 +112,7 @@ class ExtensionWebstorePrivateApiTest : public ExtensionApiTest {
extensions::ExtensionInstallUI::set_disable_failure_ui_for_tests();
}
- virtual void SetUpOnMainThread() override {
+ void SetUpOnMainThread() override {
ExtensionApiTest::SetUpOnMainThread();
ExtensionInstallPrompt::g_auto_confirm_for_tests =
@@ -398,7 +398,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebstoreGetWebGLStatusTest, Blocked) {
class EphemeralAppWebstorePrivateApiTest
: public ExtensionWebstorePrivateApiTest {
public:
- virtual void SetUpInProcessBrowserTestFixture() override {
+ void SetUpInProcessBrowserTestFixture() override {
ExtensionWebstorePrivateApiTest::SetUpInProcessBrowserTestFixture();
net::HostPortPair host_port = test_server()->host_port_pair();
@@ -410,7 +410,7 @@ class EphemeralAppWebstorePrivateApiTest
switches::kAppsGalleryURL, test_gallery_url);
}
- virtual GURL GetTestServerURL(const std::string& path) override {
+ GURL GetTestServerURL(const std::string& path) override {
return DoGetTestServerURL(
std::string("files/extensions/platform_apps/ephemeral_launcher/") +
path);

Powered by Google App Engine
This is Rietveld 408576698