chrome/browser/extensions/proxy_overridden_bubble_controller.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/proxy_overridden_bubble_controller.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/process_management_browsertest.cc ('k') | chrome/browser/extensions/proxy_overridden_bubble_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/proxy_overridden_bubble_controller.h

diff --git a/chrome/browser/extensions/proxy_overridden_bubble_controller.h b/chrome/browser/extensions/proxy_overridden_bubble_controller.h

index e5f6b9057664ea11fe568c78650cea34e32289d8..7ff8e002f7b904e68b205bcb8b78b213a762cb81 100644

--- a/chrome/browser/extensions/proxy_overridden_bubble_controller.h

+++ b/chrome/browser/extensions/proxy_overridden_bubble_controller.h

@@ -18,14 +18,14 @@ class ProxyOverriddenBubbleController

: public ExtensionMessageBubbleController {

public:

explicit ProxyOverriddenBubbleController(Profile* profile);

- virtual ~ProxyOverriddenBubbleController();

+ ~ProxyOverriddenBubbleController() override;

// Whether the controller knows that we should show the bubble for extension

// with |extension_id|. Returns true if so.

bool ShouldShow(const std::string& extension_id);

// ExtensionMessageBubbleController:

- virtual bool CloseOnDeactivate() override;

+ bool CloseOnDeactivate() override;

private:

// A weak pointer to the profile we are associated with. Not owned by us.