Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5144)

Unified Diff: chrome/browser/extensions/settings_api_bubble_controller.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/settings_api_bubble_controller.cc
diff --git a/chrome/browser/extensions/settings_api_bubble_controller.cc b/chrome/browser/extensions/settings_api_bubble_controller.cc
index 9682442698db34f0e98769c41fd9ec00254e2576..e89f42f129033152457ea5d93a2587c2347aeaa3 100644
--- a/chrome/browser/extensions/settings_api_bubble_controller.cc
+++ b/chrome/browser/extensions/settings_api_bubble_controller.cc
@@ -37,26 +37,25 @@ class SettingsApiBubbleDelegate
explicit SettingsApiBubbleDelegate(ExtensionService* service,
Profile* profile,
SettingsApiOverrideType type);
- virtual ~SettingsApiBubbleDelegate();
+ ~SettingsApiBubbleDelegate() override;
// ExtensionMessageBubbleController::Delegate methods.
- virtual bool ShouldIncludeExtension(const std::string& extension_id) override;
- virtual void AcknowledgeExtension(
+ bool ShouldIncludeExtension(const std::string& extension_id) override;
+ void AcknowledgeExtension(
const std::string& extension_id,
ExtensionMessageBubbleController::BubbleAction user_action) override;
- virtual void PerformAction(const ExtensionIdList& list) override;
- virtual void OnClose() override;
- virtual base::string16 GetTitle() const override;
- virtual base::string16 GetMessageBody(
- bool anchored_to_browser_action) const override;
- virtual base::string16 GetOverflowText(
+ void PerformAction(const ExtensionIdList& list) override;
+ void OnClose() override;
+ base::string16 GetTitle() const override;
+ base::string16 GetMessageBody(bool anchored_to_browser_action) const override;
+ base::string16 GetOverflowText(
const base::string16& overflow_count) const override;
- virtual GURL GetLearnMoreUrl() const override;
- virtual base::string16 GetActionButtonLabel() const override;
- virtual base::string16 GetDismissButtonLabel() const override;
- virtual bool ShouldShowExtensionList() const override;
- virtual void LogExtensionCount(size_t count) override;
- virtual void LogAction(
+ GURL GetLearnMoreUrl() const override;
+ base::string16 GetActionButtonLabel() const override;
+ base::string16 GetDismissButtonLabel() const override;
+ bool ShouldShowExtensionList() const override;
+ void LogExtensionCount(size_t count) override;
+ void LogAction(
ExtensionMessageBubbleController::BubbleAction action) override;
private:
« no previous file with comments | « chrome/browser/extensions/settings_api_bubble_controller.h ('k') | chrome/browser/extensions/shared_module_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698