Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chrome/browser/extensions/api/sessions/sessions_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/sessions/sessions_api.h
diff --git a/chrome/browser/extensions/api/sessions/sessions_api.h b/chrome/browser/extensions/api/sessions/sessions_api.h
index 86c4c8b65cd00310449e0972efef36da265f1c7d..8f572c00d9294670a8c4112e29c203c22cd8df11 100644
--- a/chrome/browser/extensions/api/sessions/sessions_api.h
+++ b/chrome/browser/extensions/api/sessions/sessions_api.h
@@ -28,8 +28,8 @@ class SessionId;
class SessionsGetRecentlyClosedFunction : public ChromeSyncExtensionFunction {
protected:
- virtual ~SessionsGetRecentlyClosedFunction() {}
- virtual bool RunSync() override;
+ ~SessionsGetRecentlyClosedFunction() override {}
+ bool RunSync() override;
DECLARE_EXTENSION_FUNCTION("sessions.getRecentlyClosed",
SESSIONS_GETRECENTLYCLOSED)
@@ -46,8 +46,8 @@ class SessionsGetRecentlyClosedFunction : public ChromeSyncExtensionFunction {
class SessionsGetDevicesFunction : public ChromeSyncExtensionFunction {
protected:
- virtual ~SessionsGetDevicesFunction() {}
- virtual bool RunSync() override;
+ ~SessionsGetDevicesFunction() override {}
+ bool RunSync() override;
DECLARE_EXTENSION_FUNCTION("sessions.getDevices", SESSIONS_GETDEVICES)
private:
@@ -67,8 +67,8 @@ class SessionsGetDevicesFunction : public ChromeSyncExtensionFunction {
class SessionsRestoreFunction : public ChromeSyncExtensionFunction {
protected:
- virtual ~SessionsRestoreFunction() {}
- virtual bool RunSync() override;
+ ~SessionsRestoreFunction() override {}
+ bool RunSync() override;
DECLARE_EXTENSION_FUNCTION("sessions.restore", SESSIONS_RESTORE)
private:
@@ -84,16 +84,16 @@ class SessionsRestoreFunction : public ChromeSyncExtensionFunction {
class SessionsEventRouter : public TabRestoreServiceObserver {
public:
explicit SessionsEventRouter(Profile* profile);
- virtual ~SessionsEventRouter();
+ ~SessionsEventRouter() override;
// Observer callback for TabRestoreServiceObserver. Sends data on
// recently closed tabs to the javascript side of this page to
// display to the user.
- virtual void TabRestoreServiceChanged(TabRestoreService* service) override;
+ void TabRestoreServiceChanged(TabRestoreService* service) override;
// Observer callback to notice when our associated TabRestoreService
// is destroyed.
- virtual void TabRestoreServiceDestroyed(TabRestoreService* service) override;
+ void TabRestoreServiceDestroyed(TabRestoreService* service) override;
private:
Profile* profile_;
@@ -108,17 +108,16 @@ class SessionsAPI : public BrowserContextKeyedAPI,
public extensions::EventRouter::Observer {
public:
explicit SessionsAPI(content::BrowserContext* context);
- virtual ~SessionsAPI();
+ ~SessionsAPI() override;
// BrowserContextKeyedService implementation.
- virtual void Shutdown() override;
+ void Shutdown() override;
// BrowserContextKeyedAPI implementation.
static BrowserContextKeyedAPIFactory<SessionsAPI>* GetFactoryInstance();
// EventRouter::Observer implementation.
- virtual void OnListenerAdded(const extensions::EventListenerInfo& details)
- override;
+ void OnListenerAdded(const extensions::EventListenerInfo& details) override;
private:
friend class BrowserContextKeyedAPIFactory<SessionsAPI>;

Powered by Google App Engine
This is Rietveld 408576698