Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Unified Diff: chrome/browser/extensions/extension_system_impl.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_system_impl.cc
diff --git a/chrome/browser/extensions/extension_system_impl.cc b/chrome/browser/extensions/extension_system_impl.cc
index 1e1120a16bf9201e5c3923292bf6bfa8e57ca9cf..6e08e4b046465bc5f9c23cfa4b2a4ce11fe70763 100644
--- a/chrome/browser/extensions/extension_system_impl.cc
+++ b/chrome/browser/extensions/extension_system_impl.cc
@@ -159,9 +159,9 @@ class ContentVerifierDelegateImpl : public ContentVerifierDelegate {
explicit ContentVerifierDelegateImpl(ExtensionService* service)
: service_(service->AsWeakPtr()), default_mode_(GetDefaultMode()) {}
- virtual ~ContentVerifierDelegateImpl() {}
+ ~ContentVerifierDelegateImpl() override {}
- virtual Mode ShouldBeVerified(const Extension& extension) override {
+ Mode ShouldBeVerified(const Extension& extension) override {
#if defined(OS_CHROMEOS)
if (ExtensionAssetsManagerChromeOS::IsSharedInstall(&extension))
return ContentVerifierDelegate::ENFORCE_STRICT;
@@ -184,15 +184,15 @@ class ContentVerifierDelegateImpl : public ContentVerifierDelegate {
return default_mode_;
}
- virtual const ContentVerifierKey& PublicKey() override {
+ const ContentVerifierKey& PublicKey() override {
static ContentVerifierKey key(
extension_misc::kWebstoreSignaturesPublicKey,
extension_misc::kWebstoreSignaturesPublicKeySize);
return key;
}
- virtual GURL GetSignatureFetchUrl(const std::string& extension_id,
- const base::Version& version) override {
+ GURL GetSignatureFetchUrl(const std::string& extension_id,
+ const base::Version& version) override {
// TODO(asargent) Factor out common code from the extension updater's
// ManifestFetchData class that can be shared for use here.
std::vector<std::string> parts;
@@ -210,13 +210,13 @@ class ContentVerifierDelegateImpl : public ContentVerifierDelegate {
return base_url.ReplaceComponents(replacements);
}
- virtual std::set<base::FilePath> GetBrowserImagePaths(
+ std::set<base::FilePath> GetBrowserImagePaths(
const extensions::Extension* extension) override {
return extension_file_util::GetBrowserImagePaths(extension);
}
- virtual void VerifyFailed(const std::string& extension_id,
- ContentVerifyJob::FailureReason reason) override {
+ void VerifyFailed(const std::string& extension_id,
+ ContentVerifyJob::FailureReason reason) override {
if (!service_)
return;
ExtensionRegistry* registry = ExtensionRegistry::Get(service_->profile());
« no previous file with comments | « chrome/browser/extensions/extension_system_impl.h ('k') | chrome/browser/extensions/extension_tabs_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698