Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Unified Diff: chrome/browser/extensions/chrome_url_request_util.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/chrome_url_request_util.cc
diff --git a/chrome/browser/extensions/chrome_url_request_util.cc b/chrome/browser/extensions/chrome_url_request_util.cc
index 6967e5d242ff87a4dd95dfd424199b3c94627ea3..b2455a324d08ba24b77e6f3defc206079c50ad6f 100644
--- a/chrome/browser/extensions/chrome_url_request_util.cc
+++ b/chrome/browser/extensions/chrome_url_request_util.cc
@@ -59,10 +59,10 @@ class URLRequestResourceBundleJob : public net::URLRequestSimpleJob {
}
// Overridden from URLRequestSimpleJob:
- virtual int GetData(std::string* mime_type,
- std::string* charset,
- std::string* data,
- const net::CompletionCallback& callback) const override {
+ int GetData(std::string* mime_type,
+ std::string* charset,
+ std::string* data,
+ const net::CompletionCallback& callback) const override {
// TODO(vadimt): Remove ScopedProfile below once crbug.com/422489 is fixed.
tracked_objects::ScopedProfile tracking_profile(
FROM_HERE_WITH_EXPLICIT_FUNCTION(
@@ -96,12 +96,12 @@ class URLRequestResourceBundleJob : public net::URLRequestSimpleJob {
return net::ERR_IO_PENDING;
}
- virtual void GetResponseInfo(net::HttpResponseInfo* info) override {
+ void GetResponseInfo(net::HttpResponseInfo* info) override {
*info = response_info_;
}
private:
- virtual ~URLRequestResourceBundleJob() {}
+ ~URLRequestResourceBundleJob() override {}
void OnMimeTypeRead(std::string* out_mime_type,
std::string* charset,
« no previous file with comments | « chrome/browser/extensions/chrome_process_manager_delegate.h ('k') | chrome/browser/extensions/component_loader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698