chrome/browser/extensions/extension_icon_manager_unittest.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_icon_manager_unittest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_geolocation_apitest.cc ('k') | chrome/browser/extensions/extension_icon_source_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_icon_manager_unittest.cc

diff --git a/chrome/browser/extensions/extension_icon_manager_unittest.cc b/chrome/browser/extensions/extension_icon_manager_unittest.cc

index f9a20969fd74f662abbf68c1230a0620f4281485..9ccac69996327ab5152d22410dec62b72e6ac1bd 100644

--- a/chrome/browser/extensions/extension_icon_manager_unittest.cc

+++ b/chrome/browser/extensions/extension_icon_manager_unittest.cc

@@ -74,12 +74,12 @@ class ExtensionIconManagerTest : public testing::Test {

class TestIconManager : public ExtensionIconManager {

public:

explicit TestIconManager(ExtensionIconManagerTest* test) : test_(test) {}

- virtual ~TestIconManager() {}

+ ~TestIconManager() override {}

// Overrides the ImageLoader callback, and calls through to the base class'

// implementation. Then it lets the test know that an image load was observed.

- virtual void OnImageLoaded(const std::string& extension_id,

- const gfx::Image& image) override {

+ void OnImageLoaded(const std::string& extension_id,

+ const gfx::Image& image) override {

ExtensionIconManager::OnImageLoaded(extension_id, image);

test_->ImageLoadObserved();

}