chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_mac.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_mac.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/networking_private/networking_private_apitest.cc ('k') | chrome/browser/extensions/api/networking_private/networking_private_event_router_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_mac.cc

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_mac.cc b/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_mac.cc

index 9d5643f6c654167e0a6820ffb4053a54764860af..8d9c8503c8eaa3aff3c4298510dcc4f3bbc065e7 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_mac.cc

+++ b/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_mac.cc

@@ -22,14 +22,13 @@ class NetworkingPrivateCredentialsGetterMac

public:

explicit NetworkingPrivateCredentialsGetterMac();

- virtual void Start(

- const std::string& network_guid,

- const std::string& public_key,

- const extensions::NetworkingPrivateServiceClient::CryptoVerify::

- VerifyAndEncryptCredentialsCallback& callback) override;

+ void Start(const std::string& network_guid,

+ const std::string& public_key,

+ const extensions::NetworkingPrivateServiceClient::CryptoVerify::

+ VerifyAndEncryptCredentialsCallback& callback) override;

private:

- virtual ~NetworkingPrivateCredentialsGetterMac();

+ ~NetworkingPrivateCredentialsGetterMac() override;

DISALLOW_COPY_AND_ASSIGN(NetworkingPrivateCredentialsGetterMac);

};