Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.h
diff --git a/chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.h b/chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.h
index 4cfb70fe6a2656a1f2e36ee8637c6e407c33e94d..b9688708badff3259b5a9ab4483293dc816e0857 100644
--- a/chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.h
+++ b/chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.h
@@ -37,7 +37,7 @@ class GalleryWatchStateTracker
public MediaGalleriesPreferences::GalleryChangeObserver {
public:
explicit GalleryWatchStateTracker(Profile* profile);
- virtual ~GalleryWatchStateTracker();
+ ~GalleryWatchStateTracker() override;
// Returns the GalleryWatchStateTracker associated with the |profile|.
// Returns NULL if GalleryWatchStateTracker does not exists.
@@ -56,16 +56,16 @@ class GalleryWatchStateTracker
// Updates the state of the gallery watchers on the receipt of access
// permission changed event for the extension specified by the
// |extension_id|.
- virtual void OnPermissionAdded(MediaGalleriesPreferences* pref,
- const std::string& extension_id,
- MediaGalleryPrefId gallery_id) override;
+ void OnPermissionAdded(MediaGalleriesPreferences* pref,
+ const std::string& extension_id,
+ MediaGalleryPrefId gallery_id) override;
- virtual void OnPermissionRemoved(MediaGalleriesPreferences* pref,
- const std::string& extension_id,
- MediaGalleryPrefId gallery_id) override;
+ void OnPermissionRemoved(MediaGalleriesPreferences* pref,
+ const std::string& extension_id,
+ MediaGalleryPrefId gallery_id) override;
- virtual void OnGalleryRemoved(MediaGalleriesPreferences* pref,
- MediaGalleryPrefId gallery_id) override;
+ void OnGalleryRemoved(MediaGalleriesPreferences* pref,
+ MediaGalleryPrefId gallery_id) override;
// Returns a set of watched gallery identifiers for the extension specified
// by the |extension_id|.
@@ -90,12 +90,11 @@ class GalleryWatchStateTracker
typedef std::map<std::string, WatchedGalleriesMap> WatchedExtensionsMap;
// extensions::ExtensionRegistryObserver implementation.
- virtual void OnExtensionLoaded(content::BrowserContext* browser_context,
- const Extension* extension) override;
- virtual void OnExtensionUnloaded(content::BrowserContext* browser_context,
- const Extension* extension,
- UnloadedExtensionInfo::Reason reason)
- override;
+ void OnExtensionLoaded(content::BrowserContext* browser_context,
+ const Extension* extension) override;
+ void OnExtensionUnloaded(content::BrowserContext* browser_context,
+ const Extension* extension,
+ UnloadedExtensionInfo::Reason reason) override;
// Syncs media gallery watch data for the given extension to/from the state
// storage.

Powered by Google App Engine
This is Rietveld 408576698