Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chrome/browser/extensions/tab_helper.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/tab_helper.h
diff --git a/chrome/browser/extensions/tab_helper.h b/chrome/browser/extensions/tab_helper.h
index 0c2772b2131e1ad74305d0de7747b69681123459..5dd8ac352e49f41ec30866873c162539c489be6a 100644
--- a/chrome/browser/extensions/tab_helper.h
+++ b/chrome/browser/extensions/tab_helper.h
@@ -51,7 +51,7 @@ class TabHelper : public content::WebContentsObserver,
public content::NotificationObserver,
public content::WebContentsUserData<TabHelper> {
public:
- virtual ~TabHelper();
+ ~TabHelper() override;
void CreateApplicationShortcuts();
void CreateHostedAppFromWebContents();
@@ -141,23 +141,20 @@ class TabHelper : public content::WebContentsObserver,
const WebApplicationInfo& web_app_info);
// content::WebContentsObserver overrides.
- virtual void RenderViewCreated(
- content::RenderViewHost* render_view_host) override;
- virtual void DidNavigateMainFrame(
+ void RenderViewCreated(content::RenderViewHost* render_view_host) override;
+ void DidNavigateMainFrame(
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params) override;
- virtual bool OnMessageReceived(const IPC::Message& message) override;
- virtual bool OnMessageReceived(
- const IPC::Message& message,
- content::RenderFrameHost* render_frame_host) override;
- virtual void DidCloneToNewWebContents(
+ bool OnMessageReceived(const IPC::Message& message) override;
+ bool OnMessageReceived(const IPC::Message& message,
+ content::RenderFrameHost* render_frame_host) override;
+ void DidCloneToNewWebContents(
content::WebContents* old_web_contents,
content::WebContents* new_web_contents) override;
// extensions::ExtensionFunctionDispatcher::Delegate overrides.
- virtual extensions::WindowController* GetExtensionWindowController()
- const override;
- virtual content::WebContents* GetAssociatedWebContents() const override;
+ extensions::WindowController* GetExtensionWindowController() const override;
+ content::WebContents* GetAssociatedWebContents() const override;
// Message handlers.
void OnDidGetWebApplicationInfo(const WebApplicationInfo& info);
@@ -197,9 +194,9 @@ class TabHelper : public content::WebContentsObserver,
webstore_install::Result result);
// content::NotificationObserver.
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override;
// Requests application info for the specified page. This is an asynchronous
// request. The delegate is notified by way of OnDidGetApplicationInfo when
« no previous file with comments | « chrome/browser/extensions/suspicious_extension_bubble_controller.cc ('k') | chrome/browser/extensions/test_blacklist.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698