chrome/browser/extensions/api/management/management_api.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_api.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/management/management_api.h ('k') | chrome/browser/extensions/api/management/management_api_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/management_api.cc

diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc

index abd6d4dd72966ed699c26a1eabd548c9bb163289..f13f883227c6e603c278c576bba8a0046371521b 100644

--- a/chrome/browser/extensions/api/management/management_api.cc

+++ b/chrome/browser/extensions/api/management/management_api.cc

@@ -380,7 +380,7 @@ class SafeManifestJSONParser : public UtilityProcessHostClient {

host->Send(new ChromeUtilityMsg_ParseJSON(manifest_));

}

- virtual bool OnMessageReceived(const IPC::Message& message) override {

+ bool OnMessageReceived(const IPC::Message& message) override {

bool handled = true;

IPC_BEGIN_MESSAGE_MAP(SafeManifestJSONParser, message)

IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_ParseJSON_Succeeded,

@@ -426,7 +426,7 @@ class SafeManifestJSONParser : public UtilityProcessHostClient {

}

private:

- virtual ~SafeManifestJSONParser() {}

+ ~SafeManifestJSONParser() override {}

// The client who we'll report results back to.

ManagementGetPermissionWarningsByManifestFunction* client_;