chrome/browser/extensions/signin/gaia_auth_extension_loader.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/signin/gaia_auth_extension_loader.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/shared_user_script_master.h ('k') | chrome/browser/extensions/standard_management_policy_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/signin/gaia_auth_extension_loader.h

diff --git a/chrome/browser/extensions/signin/gaia_auth_extension_loader.h b/chrome/browser/extensions/signin/gaia_auth_extension_loader.h

index 788e70cf055d7b9471048bb7555ba6562b92c912..20fd46482a3e8fc338f7868e1ef895e6b42f409c 100644

--- a/chrome/browser/extensions/signin/gaia_auth_extension_loader.h

+++ b/chrome/browser/extensions/signin/gaia_auth_extension_loader.h

@@ -22,7 +22,7 @@ const char kGaiaAuthExtensionOrigin[] =

class GaiaAuthExtensionLoader : public BrowserContextKeyedAPI {

public:

explicit GaiaAuthExtensionLoader(content::BrowserContext* context);

- virtual ~GaiaAuthExtensionLoader();

+ ~GaiaAuthExtensionLoader() override;

// Load the gaia auth extension if the extension is not loaded yet.

void LoadIfNeeded();

@@ -39,7 +39,7 @@ class GaiaAuthExtensionLoader : public BrowserContextKeyedAPI {

friend class BrowserContextKeyedAPIFactory<GaiaAuthExtensionLoader>;

// KeyedService overrides:

- virtual void Shutdown() override;

+ void Shutdown() override;

// BrowserContextKeyedAPI implementation.

static const char* service_name() {