chrome/browser/extensions/window_open_apitest.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/window_open_apitest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/webstore_startup_installer_browsertest.cc ('k') | chrome/browser/extensions/window_open_interactive_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/window_open_apitest.cc

diff --git a/chrome/browser/extensions/window_open_apitest.cc b/chrome/browser/extensions/window_open_apitest.cc

index cd3d11a8e9dd84ec4d57e6a9af5c24dd3a635417..d0a0c0c66ade7e53f6dafbe48463316c7f4882db 100644

--- a/chrome/browser/extensions/window_open_apitest.cc

+++ b/chrome/browser/extensions/window_open_apitest.cc

@@ -233,7 +233,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WindowArgumentsOverflow) {

}

class WindowOpenPanelDisabledTest : public ExtensionApiTest {

- virtual void SetUpCommandLine(CommandLine* command_line) override {

+ void SetUpCommandLine(CommandLine* command_line) override {

ExtensionApiTest::SetUpCommandLine(command_line);

// TODO(jennb): Re-enable when panels are enabled by default.

// command_line->AppendSwitch(switches::kDisablePanels);

@@ -246,7 +246,7 @@ IN_PROC_BROWSER_TEST_F(WindowOpenPanelDisabledTest,

}

class WindowOpenPanelTest : public ExtensionApiTest {

- virtual void SetUpCommandLine(CommandLine* command_line) override {

+ void SetUpCommandLine(CommandLine* command_line) override {

ExtensionApiTest::SetUpCommandLine(command_line);

command_line->AppendSwitch(switches::kEnablePanels);

}