chrome/browser/extensions/favicon_downloader.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/favicon_downloader.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/fake_safe_browsing_database_manager.h ('k') | chrome/browser/extensions/favicon_downloader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/favicon_downloader.h

diff --git a/chrome/browser/extensions/favicon_downloader.h b/chrome/browser/extensions/favicon_downloader.h

index e9142709c235bc4043ec0b8831719586c2edefca..e3b73a864f3c74cc00afcbfa618bc924a7dd23ff 100644

--- a/chrome/browser/extensions/favicon_downloader.h

+++ b/chrome/browser/extensions/favicon_downloader.h

@@ -37,7 +37,7 @@ class FaviconDownloader : public content::WebContentsObserver {

FaviconDownloader(content::WebContents* web_contents,

const std::vector<GURL>& extra_favicon_urls,

FaviconDownloaderCallback callback);

- virtual ~FaviconDownloader();

+ ~FaviconDownloader() override;

void Start();

@@ -65,10 +65,10 @@ class FaviconDownloader : public content::WebContentsObserver {

const std::vector<gfx::Size>& original_bitmap_sizes);

// content::WebContentsObserver overrides:

- virtual void DidNavigateMainFrame(

+ void DidNavigateMainFrame(

const content::LoadCommittedDetails& details,

const content::FrameNavigateParams& params) override;

- virtual void DidUpdateFaviconURL(

+ void DidUpdateFaviconURL(

const std::vector<content::FaviconURL>& candidates) override;

// Whether we have received favicons from the renderer.