chrome/browser/extensions/webstore_install_helper.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_install_helper.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/webstore_inline_installer_unittest.cc ('k') | chrome/browser/extensions/webstore_install_with_prompt.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/webstore_install_helper.h

diff --git a/chrome/browser/extensions/webstore_install_helper.h b/chrome/browser/extensions/webstore_install_helper.h

index bcb1f822db3dc753d553e8298d97db8fab575832..36cdd2440299d98d6934e9a2c5d51a9a49319e13 100644

--- a/chrome/browser/extensions/webstore_install_helper.h

+++ b/chrome/browser/extensions/webstore_install_helper.h

@@ -76,7 +76,7 @@ class WebstoreInstallHelper : public content::UtilityProcessHostClient,

void Start();

private:

- virtual ~WebstoreInstallHelper();

+ ~WebstoreInstallHelper() override;

void StartWorkOnIOThread();

void StartFetchedImageDecode();

@@ -84,10 +84,10 @@ class WebstoreInstallHelper : public content::UtilityProcessHostClient,

void ReportResultFromUIThread();

// Implementing the net::URLFetcherDelegate interface.

- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;

+ void OnURLFetchComplete(const net::URLFetcher* source) override;

// Implementing pieces of the UtilityProcessHostClient interface.

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ bool OnMessageReceived(const IPC::Message& message) override;

// Message handlers.

void OnDecodeImageSucceeded(const SkBitmap& decoded_image);