chrome/browser/extensions/extension_context_menu_model.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_context_menu_model.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_context_menu_browsertest.cc ('k') | chrome/browser/extensions/extension_crash_recovery_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_context_menu_model.h

diff --git a/chrome/browser/extensions/extension_context_menu_model.h b/chrome/browser/extensions/extension_context_menu_model.h

index ec6f1d52c3e4e61d28b744f729cdf297a6b836e5..264c31d0bb39b1e29b6a89b7d44f7fd62b1190e3 100644

--- a/chrome/browser/extensions/extension_context_menu_model.h

+++ b/chrome/browser/extensions/extension_context_menu_model.h

@@ -71,22 +71,21 @@ class ExtensionContextMenuModel

Browser* browser);

// SimpleMenuModel::Delegate overrides.

- virtual bool IsCommandIdChecked(int command_id) const override;

- virtual bool IsCommandIdEnabled(int command_id) const override;

- virtual bool GetAcceleratorForCommandId(

- int command_id,

- ui::Accelerator* accelerator) override;

- virtual void ExecuteCommand(int command_id, int event_flags) override;

+ bool IsCommandIdChecked(int command_id) const override;

+ bool IsCommandIdEnabled(int command_id) const override;

+ bool GetAcceleratorForCommandId(int command_id,

+ ui::Accelerator* accelerator) override;

+ void ExecuteCommand(int command_id, int event_flags) override;

// ExtensionUninstallDialog::Delegate:

- virtual void ExtensionUninstallAccepted() override;

- virtual void ExtensionUninstallCanceled() override;

+ void ExtensionUninstallAccepted() override;

+ void ExtensionUninstallCanceled() override;

private:

friend class base::RefCounted<ExtensionContextMenuModel>;

friend class extensions::ExtensionContextMenuModelTest;

- virtual ~ExtensionContextMenuModel();

+ ~ExtensionContextMenuModel() override;

void InitMenu(const extensions::Extension* extension);