chrome/browser/extensions/api/messaging/native_process_launcher.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_process_launcher.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/native_messaging_policy_handler.h ('k') | chrome/browser/extensions/api/metrics_private/metrics_private_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/native_process_launcher.cc

diff --git a/chrome/browser/extensions/api/messaging/native_process_launcher.cc b/chrome/browser/extensions/api/messaging/native_process_launcher.cc

index 8073b79677ce8541c1f35939cf8af5713abb1ffa..dabcbb3e2ccce85d7130859200d68d7848d74207 100644

--- a/chrome/browser/extensions/api/messaging/native_process_launcher.cc

+++ b/chrome/browser/extensions/api/messaging/native_process_launcher.cc

@@ -39,11 +39,11 @@ class NativeProcessLauncherImpl : public NativeProcessLauncher {

public:

NativeProcessLauncherImpl(bool allow_user_level_hosts,

intptr_t native_window);

- virtual ~NativeProcessLauncherImpl();

+ ~NativeProcessLauncherImpl() override;

- virtual void Launch(const GURL& origin,

- const std::string& native_host_name,

- LaunchedCallback callback) const override;

+ void Launch(const GURL& origin,

+ const std::string& native_host_name,

+ LaunchedCallback callback) const override;

private:

class Core : public base::RefCountedThreadSafe<Core> {