Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Unified Diff: chrome/browser/extensions/webstore_standalone_installer.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/webstore_standalone_installer.h
diff --git a/chrome/browser/extensions/webstore_standalone_installer.h b/chrome/browser/extensions/webstore_standalone_installer.h
index 4f42b9bb72d51c061c5935dfa7ff5c5fd10541ca..baea51499f314aafe09b8a2873708eca2b659935 100644
--- a/chrome/browser/extensions/webstore_standalone_installer.h
+++ b/chrome/browser/extensions/webstore_standalone_installer.h
@@ -62,7 +62,7 @@ class WebstoreStandaloneInstaller
void BeginInstall();
protected:
- virtual ~WebstoreStandaloneInstaller();
+ ~WebstoreStandaloneInstaller() override;
// Runs the callback; primarily used for running a callback before it is
// cleared in AbortInstall().
@@ -152,8 +152,8 @@ class WebstoreStandaloneInstaller
virtual scoped_ptr<WebstoreInstaller::Approval> CreateApproval() const;
// ExtensionInstallPrompt::Delegate interface implementation.
- virtual void InstallUIProceed() override;
- virtual void InstallUIAbort(bool user_initiated) override;
+ void InstallUIProceed() override;
+ void InstallUIAbort(bool user_initiated) override;
// Accessors to be used by subclasses.
bool show_user_count() const { return show_user_count_; }
@@ -193,27 +193,24 @@ class WebstoreStandaloneInstaller
// informs our delegate of success/failure.
// WebstoreDataFetcherDelegate interface implementation.
- virtual void OnWebstoreRequestFailure() override;
+ void OnWebstoreRequestFailure() override;
- virtual void OnWebstoreResponseParseSuccess(
+ void OnWebstoreResponseParseSuccess(
scoped_ptr<base::DictionaryValue> webstore_data) override;
- virtual void OnWebstoreResponseParseFailure(
- const std::string& error) override;
+ void OnWebstoreResponseParseFailure(const std::string& error) override;
// WebstoreInstallHelper::Delegate interface implementation.
- virtual void OnWebstoreParseSuccess(
- const std::string& id,
- const SkBitmap& icon,
- base::DictionaryValue* parsed_manifest) override;
- virtual void OnWebstoreParseFailure(
- const std::string& id,
- InstallHelperResultCode result_code,
- const std::string& error_message) override;
+ void OnWebstoreParseSuccess(const std::string& id,
+ const SkBitmap& icon,
+ base::DictionaryValue* parsed_manifest) override;
+ void OnWebstoreParseFailure(const std::string& id,
+ InstallHelperResultCode result_code,
+ const std::string& error_message) override;
// WebstoreInstaller::Delegate interface implementation.
- virtual void OnExtensionInstallSuccess(const std::string& id) override;
- virtual void OnExtensionInstallFailure(
+ void OnExtensionInstallSuccess(const std::string& id) override;
+ void OnExtensionInstallFailure(
const std::string& id,
const std::string& error,
WebstoreInstaller::FailureReason reason) override;
« no previous file with comments | « chrome/browser/extensions/webstore_reinstaller.h ('k') | chrome/browser/extensions/webstore_startup_installer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698