chrome/browser/extensions/extension_startup_browsertest.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_startup_browsertest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_special_storage_policy_unittest.cc ('k') | chrome/browser/extensions/extension_storage_monitor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_startup_browsertest.cc

diff --git a/chrome/browser/extensions/extension_startup_browsertest.cc b/chrome/browser/extensions/extension_startup_browsertest.cc

index 3dc5763ff08876513dc8b72750d26a4f4a160c46..5b59b804f046891babccc1fe5cacea7259edf4ca 100644

--- a/chrome/browser/extensions/extension_startup_browsertest.cc

+++ b/chrome/browser/extensions/extension_startup_browsertest.cc

@@ -50,7 +50,7 @@ class ExtensionStartupTestBase : public InProcessBrowserTest {

protected:

// InProcessBrowserTest

- virtual void SetUpCommandLine(CommandLine* command_line) override {

+ void SetUpCommandLine(CommandLine* command_line) override {

if (load_extensions_.empty()) {

// If no |load_extensions_| were specified, allow unauthenticated

// extension settings to be loaded from Preferences as if they had been

@@ -74,7 +74,7 @@ class ExtensionStartupTestBase : public InProcessBrowserTest {

}

- virtual bool SetUpUserDataDirectory() override {

+ bool SetUpUserDataDirectory() override {

base::FilePath profile_dir;

PathService::Get(chrome::DIR_USER_DATA, &profile_dir);

profile_dir = profile_dir.AppendASCII(TestingProfile::kTestUserProfileDir);