chrome/browser/extensions/extension_storage_monitor.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_storage_monitor.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_storage_monitor.h ('k') | chrome/browser/extensions/extension_storage_monitor_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_storage_monitor.cc

diff --git a/chrome/browser/extensions/extension_storage_monitor.cc b/chrome/browser/extensions/extension_storage_monitor.cc

index 4a0cd83a3b88a389fc4b5bf65eedc0dce187d430..654d843381b4e51ca90489247f2b01d11ac3c722 100644

--- a/chrome/browser/extensions/extension_storage_monitor.cc

+++ b/chrome/browser/extensions/extension_storage_monitor.cc

@@ -215,13 +215,13 @@ class StorageEventObserver

};

typedef std::map<GURL, StorageState> OriginStorageStateMap;

- virtual ~StorageEventObserver() {

+ ~StorageEventObserver() override {

DCHECK(origin_state_map_.empty());

StopObserving();

}

// storage::StorageObserver implementation.

- virtual void OnStorageEvent(const Event& event) override {

+ void OnStorageEvent(const Event& event) override {

OriginStorageStateMap::iterator iter =

origin_state_map_.find(event.filter.origin);

if (iter == origin_state_map_.end())