chrome/browser/extensions/api/system_indicator/system_indicator_api.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_indicator/system_indicator_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/system_display/system_display_apitest.cc ('k') | chrome/browser/extensions/api/system_indicator/system_indicator_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_indicator/system_indicator_api.h

diff --git a/chrome/browser/extensions/api/system_indicator/system_indicator_api.h b/chrome/browser/extensions/api/system_indicator/system_indicator_api.h

index 5e50790cebabcc4996bd4dc9b37f1be7e05f6ca3..1fe28267feee8fc1c848083c812feebfdd958b7c 100644

--- a/chrome/browser/extensions/api/system_indicator/system_indicator_api.h

+++ b/chrome/browser/extensions/api/system_indicator/system_indicator_api.h

@@ -17,7 +17,7 @@ class SystemIndicatorSetIconFunction : public ExtensionActionSetIconFunction {

DECLARE_EXTENSION_FUNCTION("systemIndicator.setIcon", SYSTEMINDICATOR_SETICON)

protected:

- virtual ~SystemIndicatorSetIconFunction() {}

+ ~SystemIndicatorSetIconFunction() override {}

};

class SystemIndicatorEnableFunction : public ExtensionActionShowFunction {

@@ -25,7 +25,7 @@ class SystemIndicatorEnableFunction : public ExtensionActionShowFunction {

DECLARE_EXTENSION_FUNCTION("systemIndicator.enable", SYSTEMINDICATOR_ENABLE)

protected:

- virtual ~SystemIndicatorEnableFunction() {}

+ ~SystemIndicatorEnableFunction() override {}

};

class SystemIndicatorDisableFunction : public ExtensionActionHideFunction {

@@ -33,7 +33,7 @@ class SystemIndicatorDisableFunction : public ExtensionActionHideFunction {

DECLARE_EXTENSION_FUNCTION("systemIndicator.disable", SYSTEMINDICATOR_DISABLE)

protected:

- virtual ~SystemIndicatorDisableFunction() {}

+ ~SystemIndicatorDisableFunction() override {}

};

} // namespace extensions