chrome/browser/extensions/unpacked_installer.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/unpacked_installer.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/token_cache/token_cache_service_factory.h ('k') | chrome/browser/extensions/updater/extension_cache_fake.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/unpacked_installer.cc

diff --git a/chrome/browser/extensions/unpacked_installer.cc b/chrome/browser/extensions/unpacked_installer.cc

index cf49ab36405621608f8a57733fe752731f616d85..0c72346e725747134e32feb2f3fedc6befb421c6 100644

--- a/chrome/browser/extensions/unpacked_installer.cc

+++ b/chrome/browser/extensions/unpacked_installer.cc

@@ -50,13 +50,13 @@ class SimpleExtensionLoadPrompt : public ExtensionInstallPrompt::Delegate {

SimpleExtensionLoadPrompt(const Extension* extension,

Profile* profile,

const base::Closure& callback);

- virtual ~SimpleExtensionLoadPrompt();

+ ~SimpleExtensionLoadPrompt() override;

void ShowPrompt();

// ExtensionInstallUI::Delegate

- virtual void InstallUIProceed() override;

- virtual void InstallUIAbort(bool user_initiated) override;

+ void InstallUIProceed() override;

+ void InstallUIAbort(bool user_initiated) override;

private:

scoped_ptr<ExtensionInstallPrompt> install_ui_;