chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/streams_private/streams_private_apitest.cc ('k') | chrome/browser/extensions/api/sync_file_system/sync_file_system_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.h

diff --git a/chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.h b/chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.h

index e50c9c650d9cbcce2fff349473d738373e6a0320..413f6992d079dcb677924b97940c13b74e40304e 100644

--- a/chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.h

+++ b/chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.h

@@ -30,25 +30,24 @@ class ExtensionSyncEventObserver : public sync_file_system::SyncEventObserver,

GetFactoryInstance();

explicit ExtensionSyncEventObserver(content::BrowserContext* context);

- virtual ~ExtensionSyncEventObserver();

+ ~ExtensionSyncEventObserver() override;

void InitializeForService(

sync_file_system::SyncFileSystemService* sync_service);

// KeyedService override.

- virtual void Shutdown() override;

+ void Shutdown() override;

// sync_file_system::SyncEventObserver interface implementation.

- virtual void OnSyncStateUpdated(

- const GURL& app_origin,

- sync_file_system::SyncServiceState state,

- const std::string& description) override;

- virtual void OnFileSynced(const storage::FileSystemURL& url,

- sync_file_system::SyncFileType file_type,

- sync_file_system::SyncFileStatus status,

- sync_file_system::SyncAction action,

- sync_file_system::SyncDirection direction) override;

+ void OnSyncStateUpdated(const GURL& app_origin,

+ sync_file_system::SyncServiceState state,

+ const std::string& description) override;

+ void OnFileSynced(const storage::FileSystemURL& url,

+ sync_file_system::SyncFileType file_type,

+ sync_file_system::SyncFileStatus status,

+ sync_file_system::SyncAction action,

+ sync_file_system::SyncDirection direction) override;

private:

friend class BrowserContextKeyedAPIFactory<ExtensionSyncEventObserver>;