Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: chrome/browser/extensions/bookmark_app_helper_unittest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/bookmark_app_helper.h" 5 #include "chrome/browser/extensions/bookmark_app_helper.h"
6 6
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/browser/extensions/extension_service.h" 8 #include "chrome/browser/extensions/extension_service.h"
9 #include "chrome/browser/extensions/extension_service_test_base.h" 9 #include "chrome/browser/extensions/extension_service_test_base.h"
10 #include "chrome/common/extensions/manifest_handlers/app_launch_info.h" 10 #include "chrome/common/extensions/manifest_handlers/app_launch_info.h"
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 115
116 namespace extensions { 116 namespace extensions {
117 117
118 class TestBookmarkAppHelper : public BookmarkAppHelper { 118 class TestBookmarkAppHelper : public BookmarkAppHelper {
119 public: 119 public:
120 TestBookmarkAppHelper(ExtensionService* service, 120 TestBookmarkAppHelper(ExtensionService* service,
121 WebApplicationInfo web_app_info, 121 WebApplicationInfo web_app_info,
122 content::WebContents* contents) 122 content::WebContents* contents)
123 : BookmarkAppHelper(service, web_app_info, contents) {} 123 : BookmarkAppHelper(service, web_app_info, contents) {}
124 124
125 virtual ~TestBookmarkAppHelper() {} 125 ~TestBookmarkAppHelper() override {}
126 126
127 void CreationComplete(const extensions::Extension* extension, 127 void CreationComplete(const extensions::Extension* extension,
128 const WebApplicationInfo& web_app_info) { 128 const WebApplicationInfo& web_app_info) {
129 extension_ = extension; 129 extension_ = extension;
130 } 130 }
131 131
132 void CompleteIconDownload( 132 void CompleteIconDownload(
133 bool success, 133 bool success,
134 const std::map<GURL, std::vector<SkBitmap> >& bitmaps) { 134 const std::map<GURL, std::vector<SkBitmap> >& bitmaps) {
135 BookmarkAppHelper::OnIconsDownloaded(success, bitmaps); 135 BookmarkAppHelper::OnIconsDownloaded(success, bitmaps);
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 } 326 }
327 327
328 TEST_F(BookmarkAppHelperTest, IsValidBookmarkAppUrl) { 328 TEST_F(BookmarkAppHelperTest, IsValidBookmarkAppUrl) {
329 EXPECT_TRUE(IsValidBookmarkAppUrl(GURL("https://www.chromium.org"))); 329 EXPECT_TRUE(IsValidBookmarkAppUrl(GURL("https://www.chromium.org")));
330 EXPECT_TRUE(IsValidBookmarkAppUrl(GURL("http://www.chromium.org/path"))); 330 EXPECT_TRUE(IsValidBookmarkAppUrl(GURL("http://www.chromium.org/path")));
331 EXPECT_FALSE(IsValidBookmarkAppUrl(GURL("ftp://www.chromium.org"))); 331 EXPECT_FALSE(IsValidBookmarkAppUrl(GURL("ftp://www.chromium.org")));
332 EXPECT_FALSE(IsValidBookmarkAppUrl(GURL("chrome://flags"))); 332 EXPECT_FALSE(IsValidBookmarkAppUrl(GURL("chrome://flags")));
333 } 333 }
334 334
335 } // namespace extensions 335 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/bookmark_app_helper.cc ('k') | chrome/browser/extensions/browser_extension_window_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698