Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: chrome/browser/extensions/api/synced_notifications_private/synced_notifications_shim.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_SYNCED_NOTIFICATIONS_PRIVATE_SYNCED_NOTIFI CATIONS_SHIM_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_SYNCED_NOTIFICATIONS_PRIVATE_SYNCED_NOTIFI CATIONS_SHIM_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_SYNCED_NOTIFICATIONS_PRIVATE_SYNCED_NOTIFI CATIONS_SHIM_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_SYNCED_NOTIFICATIONS_PRIVATE_SYNCED_NOTIFI CATIONS_SHIM_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/memory/scoped_ptr.h" 11 #include "base/memory/scoped_ptr.h"
12 #include "chrome/common/extensions/api/synced_notifications_private.h" 12 #include "chrome/common/extensions/api/synced_notifications_private.h"
13 #include "sync/api/syncable_service.h" 13 #include "sync/api/syncable_service.h"
14 14
15 namespace extensions { 15 namespace extensions {
16 struct Event; 16 struct Event;
17 } 17 }
18 18
19 // Shim for SYNCED_NOTIFICATIONS and SYNCED_NOTIFICATIONS_APP_INFO datatypes 19 // Shim for SYNCED_NOTIFICATIONS and SYNCED_NOTIFICATIONS_APP_INFO datatypes
20 // to interface with their extension backed sync code. 20 // to interface with their extension backed sync code.
21 class SyncedNotificationsShim : public syncer::SyncableService { 21 class SyncedNotificationsShim : public syncer::SyncableService {
22 public: 22 public:
23 // Callback for firing extension events. 23 // Callback for firing extension events.
24 typedef base::Callback<void(scoped_ptr<extensions::Event>)> EventLauncher; 24 typedef base::Callback<void(scoped_ptr<extensions::Event>)> EventLauncher;
25 25
26 explicit SyncedNotificationsShim(const EventLauncher& event_launcher, 26 explicit SyncedNotificationsShim(const EventLauncher& event_launcher,
27 const base::Closure& refresh_request); 27 const base::Closure& refresh_request);
28 virtual ~SyncedNotificationsShim(); 28 ~SyncedNotificationsShim() override;
29 29
30 // SyncableService interface. 30 // SyncableService interface.
31 virtual syncer::SyncMergeResult MergeDataAndStartSyncing( 31 syncer::SyncMergeResult MergeDataAndStartSyncing(
32 syncer::ModelType type, 32 syncer::ModelType type,
33 const syncer::SyncDataList& initial_sync_data, 33 const syncer::SyncDataList& initial_sync_data,
34 scoped_ptr<syncer::SyncChangeProcessor> sync_processor, 34 scoped_ptr<syncer::SyncChangeProcessor> sync_processor,
35 scoped_ptr<syncer::SyncErrorFactory> error_handler) override; 35 scoped_ptr<syncer::SyncErrorFactory> error_handler) override;
36 virtual void StopSyncing(syncer::ModelType type) override; 36 void StopSyncing(syncer::ModelType type) override;
37 virtual syncer::SyncError ProcessSyncChanges( 37 syncer::SyncError ProcessSyncChanges(
38 const tracked_objects::Location& from_here, 38 const tracked_objects::Location& from_here,
39 const syncer::SyncChangeList& change_list) override; 39 const syncer::SyncChangeList& change_list) override;
40 virtual syncer::SyncDataList GetAllSyncData( 40 syncer::SyncDataList GetAllSyncData(syncer::ModelType type) const override;
41 syncer::ModelType type) const override;
42 41
43 // JS interface methods (see synced_notifications_private.h). 42 // JS interface methods (see synced_notifications_private.h).
44 bool GetInitialData( 43 bool GetInitialData(
45 extensions::api::synced_notifications_private::SyncDataType data_type, 44 extensions::api::synced_notifications_private::SyncDataType data_type,
46 std::vector< 45 std::vector<
47 linked_ptr<extensions::api::synced_notifications_private::SyncData> >* 46 linked_ptr<extensions::api::synced_notifications_private::SyncData> >*
48 js_data_list) const; 47 js_data_list) const;
49 bool UpdateNotification(const std::string& changed_notification); 48 bool UpdateNotification(const std::string& changed_notification);
50 bool SetRenderContext( 49 bool SetRenderContext(
51 extensions::api::synced_notifications_private::RefreshRequest 50 extensions::api::synced_notifications_private::RefreshRequest
(...skipping 11 matching lines...) Expand all
63 base::Closure refresh_request_; 62 base::Closure refresh_request_;
64 63
65 // The sync change processors, initialized via MergeDataAndStartSyncing. 64 // The sync change processors, initialized via MergeDataAndStartSyncing.
66 scoped_ptr<syncer::SyncChangeProcessor> notifications_change_processor_; 65 scoped_ptr<syncer::SyncChangeProcessor> notifications_change_processor_;
67 scoped_ptr<syncer::SyncChangeProcessor> app_info_change_processor_; 66 scoped_ptr<syncer::SyncChangeProcessor> app_info_change_processor_;
68 67
69 DISALLOW_COPY_AND_ASSIGN(SyncedNotificationsShim); 68 DISALLOW_COPY_AND_ASSIGN(SyncedNotificationsShim);
70 }; 69 };
71 70
72 #endif // CHROME_BROWSER_EXTENSIONS_API_SYNCED_NOTIFICATIONS_PRIVATE_SYNCED_NOT IFICATIONS_SHIM_H_ 71 #endif // CHROME_BROWSER_EXTENSIONS_API_SYNCED_NOTIFICATIONS_PRIVATE_SYNCED_NOT IFICATIONS_SHIM_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698