Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_RUNTIME_CHROME_RUNTIME_API_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_RUNTIME_CHROME_RUNTIME_API_DELEGATE_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_RUNTIME_CHROME_RUNTIME_API_DELEGATE_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_RUNTIME_CHROME_RUNTIME_API_DELEGATE_H_
7 7
8 #include <map> 8 #include <map>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 15 matching lines...) Expand all
26 26
27 namespace extensions { 27 namespace extensions {
28 class RuntimeAPI; 28 class RuntimeAPI;
29 class UpdateObserver; 29 class UpdateObserver;
30 } 30 }
31 31
32 class ChromeRuntimeAPIDelegate : public extensions::RuntimeAPIDelegate, 32 class ChromeRuntimeAPIDelegate : public extensions::RuntimeAPIDelegate,
33 public content::NotificationObserver { 33 public content::NotificationObserver {
34 public: 34 public:
35 explicit ChromeRuntimeAPIDelegate(content::BrowserContext* context); 35 explicit ChromeRuntimeAPIDelegate(content::BrowserContext* context);
36 virtual ~ChromeRuntimeAPIDelegate(); 36 ~ChromeRuntimeAPIDelegate() override;
37 37
38 private: 38 private:
39 friend class extensions::RuntimeAPI; 39 friend class extensions::RuntimeAPI;
40 40
41 // extensions::RuntimeAPIDelegate implementation. 41 // extensions::RuntimeAPIDelegate implementation.
42 virtual void AddUpdateObserver(extensions::UpdateObserver* observer) override; 42 void AddUpdateObserver(extensions::UpdateObserver* observer) override;
43 virtual void RemoveUpdateObserver( 43 void RemoveUpdateObserver(extensions::UpdateObserver* observer) override;
44 extensions::UpdateObserver* observer) override; 44 base::Version GetPreviousExtensionVersion(
45 virtual base::Version GetPreviousExtensionVersion(
46 const extensions::Extension* extension) override; 45 const extensions::Extension* extension) override;
47 virtual void ReloadExtension(const std::string& extension_id) override; 46 void ReloadExtension(const std::string& extension_id) override;
48 virtual bool CheckForUpdates(const std::string& extension_id, 47 bool CheckForUpdates(const std::string& extension_id,
49 const UpdateCheckCallback& callback) override; 48 const UpdateCheckCallback& callback) override;
50 virtual void OpenURL(const GURL& uninstall_url) override; 49 void OpenURL(const GURL& uninstall_url) override;
51 virtual bool GetPlatformInfo( 50 bool GetPlatformInfo(
52 extensions::core_api::runtime::PlatformInfo* info) override; 51 extensions::core_api::runtime::PlatformInfo* info) override;
53 virtual bool RestartDevice(std::string* error_message) override; 52 bool RestartDevice(std::string* error_message) override;
54 53
55 // content::NotificationObserver implementation. 54 // content::NotificationObserver implementation.
56 virtual void Observe(int type, 55 void Observe(int type,
57 const content::NotificationSource& source, 56 const content::NotificationSource& source,
58 const content::NotificationDetails& details) override; 57 const content::NotificationDetails& details) override;
59 58
60 void UpdateCheckComplete(const std::string& extension_id); 59 void UpdateCheckComplete(const std::string& extension_id);
61 void CallUpdateCallbacks(const std::string& extension_id, 60 void CallUpdateCallbacks(const std::string& extension_id,
62 const UpdateCheckResult& result); 61 const UpdateCheckResult& result);
63 62
64 content::BrowserContext* browser_context_; 63 content::BrowserContext* browser_context_;
65 64
66 content::NotificationRegistrar registrar_; 65 content::NotificationRegistrar registrar_;
67 66
68 // Whether the API registered with the ExtensionService to receive 67 // Whether the API registered with the ExtensionService to receive
69 // update notifications. 68 // update notifications.
70 bool registered_for_updates_; 69 bool registered_for_updates_;
71 70
72 // Map to prevent extensions from getting stuck in reload loops. Maps 71 // Map to prevent extensions from getting stuck in reload loops. Maps
73 // extension id to the last time it was reloaded and the number of times 72 // extension id to the last time it was reloaded and the number of times
74 // it was reloaded with not enough time in between reloads. 73 // it was reloaded with not enough time in between reloads.
75 std::map<std::string, std::pair<base::TimeTicks, int> > last_reload_time_; 74 std::map<std::string, std::pair<base::TimeTicks, int> > last_reload_time_;
76 75
77 // Pending update checks. 76 // Pending update checks.
78 typedef std::vector<UpdateCheckCallback> UpdateCallbackList; 77 typedef std::vector<UpdateCheckCallback> UpdateCallbackList;
79 typedef std::map<std::string, UpdateCallbackList> UpdateCallbackMap; 78 typedef std::map<std::string, UpdateCallbackList> UpdateCallbackMap;
80 UpdateCallbackMap pending_update_checks_; 79 UpdateCallbackMap pending_update_checks_;
81 80
82 private: 81 private:
83 DISALLOW_COPY_AND_ASSIGN(ChromeRuntimeAPIDelegate); 82 DISALLOW_COPY_AND_ASSIGN(ChromeRuntimeAPIDelegate);
84 }; 83 };
85 84
86 #endif // CHROME_BROWSER_EXTENSIONS_API_RUNTIME_CHROME_RUNTIME_API_DELEGATE_H_ 85 #endif // CHROME_BROWSER_EXTENSIONS_API_RUNTIME_CHROME_RUNTIME_API_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698