Standardize usage of virtual/override/final in chrome/browser/extensions/

chrome/browser/extensions/api/identity/identity_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_IDENTITY_IDENTITY_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_IDENTITY_IDENTITY_API_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 75 matching lines @@
                     public gaia::AccountTracker::Observer {
  public:
   typedef std::map<ExtensionTokenKey, IdentityTokenCacheValue> CachedTokens;
 
   class ShutdownObserver {
    public:
     virtual void OnShutdown() = 0;
   };
 
   explicit IdentityAPI(content::BrowserContext* context);
-  virtual ~IdentityAPI();
+  ~IdentityAPI() override;
 
   // Request serialization queue for getAuthToken.
   IdentityMintRequestQueue* mint_queue();
 
   // Token cache
   void SetCachedToken(const ExtensionTokenKey& key,
                       const IdentityTokenCacheValue& token_data);
   void EraseCachedToken(const std::string& extension_id,
                         const std::string& token);
   void EraseAllCachedTokens();
   const IdentityTokenCacheValue& GetCachedToken(const ExtensionTokenKey& key);
 
   const CachedTokens& GetAllCachedTokens();
 
   // Account queries.
   std::vector<std::string> GetAccounts() const;
   std::string FindAccountKeyByGaiaId(const std::string& gaia_id);
 
   // BrowserContextKeyedAPI implementation.
-  virtual void Shutdown() override;
+  void Shutdown() override;
   static BrowserContextKeyedAPIFactory<IdentityAPI>* GetFactoryInstance();
 
   // gaia::AccountTracker::Observer implementation:
-  virtual void OnAccountAdded(const gaia::AccountIds& ids) override;
-  virtual void OnAccountRemoved(const gaia::AccountIds& ids) override;
-  virtual void OnAccountSignInChanged(const gaia::AccountIds& ids,
-                                      bool is_signed_in) override;
+  void OnAccountAdded(const gaia::AccountIds& ids) override;
+  void OnAccountRemoved(const gaia::AccountIds& ids) override;
+  void OnAccountSignInChanged(const gaia::AccountIds& ids,
+                              bool is_signed_in) override;
 
   void AddShutdownObserver(ShutdownObserver* observer);
   void RemoveShutdownObserver(ShutdownObserver* observer);
 
   void SetAccountStateForTest(gaia::AccountIds ids, bool is_signed_in);
 
  private:
   friend class BrowserContextKeyedAPIFactory<IdentityAPI>;
 
   // BrowserContextKeyedAPI implementation.
@@ skipping 12 matching lines @@
 void BrowserContextKeyedAPIFactory<IdentityAPI>::DeclareFactoryDependencies();
 
 class IdentityGetAccountsFunction : public ChromeUIThreadExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("identity.getAccounts",
                              IDENTITY_GETACCOUNTS);
 
   IdentityGetAccountsFunction();
 
  private:
-  virtual ~IdentityGetAccountsFunction();
+  ~IdentityGetAccountsFunction() override;
 
   // UIThreadExtensionFunction implementation.
-  virtual ExtensionFunction::ResponseAction Run() override;
+  ExtensionFunction::ResponseAction Run() override;
 };
 
 // identity.getAuthToken fetches an OAuth 2 function for the
 // caller. The request has three sub-flows: non-interactive,
 // interactive, and sign-in.
 //
 // In the non-interactive flow, getAuthToken requests a token from
 // GAIA. GAIA may respond with a token, an error, or "consent
 // required". In the consent required cases, getAuthToken proceeds to
 // the second, interactive phase.
@@ skipping 17 matching lines @@
   DECLARE_EXTENSION_FUNCTION("identity.getAuthToken",
                              EXPERIMENTAL_IDENTITY_GETAUTHTOKEN);
 
   IdentityGetAuthTokenFunction();
 
   const ExtensionTokenKey* GetExtensionTokenKeyForTest() {
     return token_key_.get();
   }
 
  protected:
-  virtual ~IdentityGetAuthTokenFunction();
+  ~IdentityGetAuthTokenFunction() override;
 
   // IdentitySigninFlow::Delegate implementation:
-  virtual void SigninSuccess() override;
-  virtual void SigninFailed() override;
+  void SigninSuccess() override;
+  void SigninFailed() override;
 
   // GaiaWebAuthFlow::Delegate implementation:
-  virtual void OnGaiaFlowFailure(GaiaWebAuthFlow::Failure failure,
-                                 GoogleServiceAuthError service_error,
-                                 const std::string& oauth_error) override;
-  virtual void OnGaiaFlowCompleted(const std::string& access_token,
-                                   const std::string& expiration) override;
+  void OnGaiaFlowFailure(GaiaWebAuthFlow::Failure failure,
+                         GoogleServiceAuthError service_error,
+                         const std::string& oauth_error) override;
+  void OnGaiaFlowCompleted(const std::string& access_token,
+                           const std::string& expiration) override;
 
   // Starts a login access token request.
   virtual void StartLoginAccessTokenRequest();
 
   // OAuth2TokenService::Consumer implementation:
-  virtual void OnGetTokenSuccess(const OAuth2TokenService::Request* request,
-                                 const std::string& access_token,
-                                 const base::Time& expiration_time) override;
-  virtual void OnGetTokenFailure(const OAuth2TokenService::Request* request,
-                                 const GoogleServiceAuthError& error) override;
+  void OnGetTokenSuccess(const OAuth2TokenService::Request* request,
+                         const std::string& access_token,
+                         const base::Time& expiration_time) override;
+  void OnGetTokenFailure(const OAuth2TokenService::Request* request,
+                         const GoogleServiceAuthError& error) override;
 
   // Starts a mint token request to GAIA.
   // Exposed for testing.
   virtual void StartGaiaRequest(const std::string& login_access_token);
 
   // Caller owns the returned instance.
   // Exposed for testing.
   virtual OAuth2MintTokenFlow* CreateMintTokenFlow();
 
   scoped_ptr<OAuth2TokenService::Request> login_token_request_;
 
  private:
   FRIEND_TEST_ALL_PREFIXES(GetAuthTokenFunctionTest,
                            ComponentWithChromeClientId);
   FRIEND_TEST_ALL_PREFIXES(GetAuthTokenFunctionTest,
                            ComponentWithNormalClientId);
   FRIEND_TEST_ALL_PREFIXES(GetAuthTokenFunctionTest, InteractiveQueueShutdown);
   FRIEND_TEST_ALL_PREFIXES(GetAuthTokenFunctionTest, NoninteractiveShutdown);
 
   // ExtensionFunction:
-  virtual bool RunAsync() override;
+  bool RunAsync() override;
 
   // Helpers to report async function results to the caller.
   void StartAsyncRun();
   void CompleteAsyncRun(bool success);
   void CompleteFunctionWithResult(const std::string& access_token);
   void CompleteFunctionWithError(const std::string& error);
 
   // Initiate/complete the sub-flows.
   void StartSigninFlow();
   void StartMintTokenFlow(IdentityMintRequestQueue::MintType type);
   void CompleteMintTokenFlow();
 
   // IdentityMintRequestQueue::Request implementation:
-  virtual void StartMintToken(IdentityMintRequestQueue::MintType type) override;
+  void StartMintToken(IdentityMintRequestQueue::MintType type) override;
 
   // OAuth2MintTokenFlow::Delegate implementation:
-  virtual void OnMintTokenSuccess(const std::string& access_token,
-                                  int time_to_live) override;
-  virtual void OnMintTokenFailure(
-      const GoogleServiceAuthError& error) override;
-  virtual void OnIssueAdviceSuccess(
-      const IssueAdviceInfo& issue_advice) override;
+  void OnMintTokenSuccess(const std::string& access_token,
+                          int time_to_live) override;
+  void OnMintTokenFailure(const GoogleServiceAuthError& error) override;
+  void OnIssueAdviceSuccess(const IssueAdviceInfo& issue_advice) override;
 
   // IdentityAPI::ShutdownObserver implementation:
-  virtual void OnShutdown() override;
+  void OnShutdown() override;
 
 #if defined(OS_CHROMEOS)
   // Starts a login access token request for device robot account. This method
   // will be called only in enterprise kiosk mode in ChromeOS.
   virtual void StartDeviceLoginAccessTokenRequest();
 #endif
 
   // Methods for invoking UI. Overridable for testing.
   virtual void ShowLoginPopup();
   virtual void ShowOAuthApprovalDialog(const IssueAdviceInfo& issue_advice);
@@ skipping 24 matching lines @@
 
 class IdentityGetProfileUserInfoFunction
     : public ChromeUIThreadExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("identity.getProfileUserInfo",
                              IDENTITY_GETPROFILEUSERINFO);
 
   IdentityGetProfileUserInfoFunction();
 
  private:
-  virtual ~IdentityGetProfileUserInfoFunction();
+  ~IdentityGetProfileUserInfoFunction() override;
 
   // UIThreadExtensionFunction implementation.
-  virtual ExtensionFunction::ResponseAction Run() override;
+  ExtensionFunction::ResponseAction Run() override;
 };
 
 class IdentityRemoveCachedAuthTokenFunction
     : public ChromeSyncExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("identity.removeCachedAuthToken",
                              EXPERIMENTAL_IDENTITY_REMOVECACHEDAUTHTOKEN)
   IdentityRemoveCachedAuthTokenFunction();
 
  protected:
-  virtual ~IdentityRemoveCachedAuthTokenFunction();
+  ~IdentityRemoveCachedAuthTokenFunction() override;
 
   // SyncExtensionFunction implementation:
-  virtual bool RunSync() override;
+  bool RunSync() override;
 };
 
 class IdentityLaunchWebAuthFlowFunction : public ChromeAsyncExtensionFunction,
                                           public WebAuthFlow::Delegate {
  public:
   DECLARE_EXTENSION_FUNCTION("identity.launchWebAuthFlow",
                              EXPERIMENTAL_IDENTITY_LAUNCHWEBAUTHFLOW);
 
   IdentityLaunchWebAuthFlowFunction();
 
   // Tests may override extension_id.
   void InitFinalRedirectURLPrefixForTest(const std::string& extension_id);
 
  private:
-  virtual ~IdentityLaunchWebAuthFlowFunction();
-  virtual bool RunAsync() override;
+  ~IdentityLaunchWebAuthFlowFunction() override;
+  bool RunAsync() override;
 
   // WebAuthFlow::Delegate implementation.
-  virtual void OnAuthFlowFailure(WebAuthFlow::Failure failure) override;
-  virtual void OnAuthFlowURLChange(const GURL& redirect_url) override;
-  virtual void OnAuthFlowTitleChange(const std::string& title) override {}
+  void OnAuthFlowFailure(WebAuthFlow::Failure failure) override;
+  void OnAuthFlowURLChange(const GURL& redirect_url) override;
+  void OnAuthFlowTitleChange(const std::string& title) override {}
 
   // Helper to initialize final URL prefix.
   void InitFinalRedirectURLPrefix(const std::string& extension_id);
 
   scoped_ptr<WebAuthFlow> auth_flow_;
   GURL final_url_prefix_;
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_IDENTITY_IDENTITY_API_H_