Standardize usage of virtual/override/final in chrome/browser/extensions/

chrome/browser/extensions/api/extension_action/extension_action_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_ACTION_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_ACTION_API_H_
 
 #include <string>
 
 #include "base/observer_list.h"
@@ skipping 37 matching lines @@
 
     // Called when the ExtensionActionAPI is shutting down, giving observers a
     // chance to unregister themselves if there is not a definitive lifecycle.
     virtual void OnExtensionActionAPIShuttingDown();
 
    protected:
     virtual ~Observer();
   };
 
   explicit ExtensionActionAPI(content::BrowserContext* context);
-  virtual ~ExtensionActionAPI();
+  ~ExtensionActionAPI() override;
 
   // Convenience method to get the instance for a profile.
   static ExtensionActionAPI* Get(content::BrowserContext* context);
 
   static bool GetBrowserActionVisibility(const ExtensionPrefs* prefs,
                                          const std::string& extension_id);
   static void SetBrowserActionVisibility(ExtensionPrefs* prefs,
                                          const std::string& extension_id,
                                          bool visible);
 
@@ skipping 48 matching lines @@
                                 const std::string& extension_id,
                                 const std::string& event_name,
                                 scoped_ptr<base::ListValue> event_args);
 
   // Called when either a browser or page action is executed. Figures out which
   // event to send based on what the extension wants.
   void ExtensionActionExecuted(const ExtensionAction& extension_action,
                                content::WebContents* web_contents);
 
   // BrowserContextKeyedAPI implementation.
-  virtual void Shutdown() override;
+  void Shutdown() override;
   static const char* service_name() { return "ExtensionActionAPI"; }
   static const bool kServiceRedirectedInIncognito = true;
 
   ObserverList<Observer> observers_;
 
   content::BrowserContext* browser_context_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionActionAPI);
 };
 
 // Implementation of the browserAction and pageAction APIs.
 //
 // Divergent behaviour between the two is minimal (pageAction has required
 // tabIds while browserAction's are optional, they have different internal
 // browser notification requirements, and not all functions are defined for all
 // APIs).
 class ExtensionActionFunction : public ChromeSyncExtensionFunction {
  public:
   static bool ParseCSSColorString(const std::string& color_string,
                                   SkColor* result);
 
  protected:
   ExtensionActionFunction();
-  virtual ~ExtensionActionFunction();
-  virtual bool RunSync() override;
+  ~ExtensionActionFunction() override;
+  bool RunSync() override;
   virtual bool RunExtensionAction() = 0;
 
   bool ExtractDataFromArguments();
   void NotifyChange();
   bool SetVisible(bool visible);
 
   // All the extension action APIs take a single argument called details that
   // is a dictionary.
   base::DictionaryValue* details_;
 
@@ skipping 11 matching lines @@
 //
 // Implementations of each extension action API.
 //
 // pageAction and browserAction bindings are created for these by extending them
 // then declaring an EXTENSION_FUNCTION_NAME.
 //
 
 // show
 class ExtensionActionShowFunction : public ExtensionActionFunction {
  protected:
-  virtual ~ExtensionActionShowFunction() {}
-  virtual bool RunExtensionAction() override;
+  ~ExtensionActionShowFunction() override {}
+  bool RunExtensionAction() override;
 };
 
 // hide
 class ExtensionActionHideFunction : public ExtensionActionFunction {
  protected:
-  virtual ~ExtensionActionHideFunction() {}
-  virtual bool RunExtensionAction() override;
+  ~ExtensionActionHideFunction() override {}
+  bool RunExtensionAction() override;
 };
 
 // setIcon
 class ExtensionActionSetIconFunction : public ExtensionActionFunction {
  protected:
-  virtual ~ExtensionActionSetIconFunction() {}
-  virtual bool RunExtensionAction() override;
+  ~ExtensionActionSetIconFunction() override {}
+  bool RunExtensionAction() override;
 };
 
 // setTitle
 class ExtensionActionSetTitleFunction : public ExtensionActionFunction {
  protected:
-  virtual ~ExtensionActionSetTitleFunction() {}
-  virtual bool RunExtensionAction() override;
+  ~ExtensionActionSetTitleFunction() override {}
+  bool RunExtensionAction() override;
 };
 
 // setPopup
 class ExtensionActionSetPopupFunction : public ExtensionActionFunction {
  protected:
-  virtual ~ExtensionActionSetPopupFunction() {}
-  virtual bool RunExtensionAction() override;
+  ~ExtensionActionSetPopupFunction() override {}
+  bool RunExtensionAction() override;
 };
 
 // setBadgeText
 class ExtensionActionSetBadgeTextFunction : public ExtensionActionFunction {
  protected:
-  virtual ~ExtensionActionSetBadgeTextFunction() {}
-  virtual bool RunExtensionAction() override;
+  ~ExtensionActionSetBadgeTextFunction() override {}
+  bool RunExtensionAction() override;
 };
 
 // setBadgeBackgroundColor
 class ExtensionActionSetBadgeBackgroundColorFunction
     : public ExtensionActionFunction {
  protected:
-  virtual ~ExtensionActionSetBadgeBackgroundColorFunction() {}
-  virtual bool RunExtensionAction() override;
+  ~ExtensionActionSetBadgeBackgroundColorFunction() override {}
+  bool RunExtensionAction() override;
 };
 
 // getTitle
 class ExtensionActionGetTitleFunction : public ExtensionActionFunction {
  protected:
-  virtual ~ExtensionActionGetTitleFunction() {}
-  virtual bool RunExtensionAction() override;
+  ~ExtensionActionGetTitleFunction() override {}
+  bool RunExtensionAction() override;
 };
 
 // getPopup
 class ExtensionActionGetPopupFunction : public ExtensionActionFunction {
  protected:
-  virtual ~ExtensionActionGetPopupFunction() {}
-  virtual bool RunExtensionAction() override;
+  ~ExtensionActionGetPopupFunction() override {}
+  bool RunExtensionAction() override;
 };
 
 // getBadgeText
 class ExtensionActionGetBadgeTextFunction : public ExtensionActionFunction {
  protected:
-  virtual ~ExtensionActionGetBadgeTextFunction() {}
-  virtual bool RunExtensionAction() override;
+  ~ExtensionActionGetBadgeTextFunction() override {}
+  bool RunExtensionAction() override;
 };
 
 // getBadgeBackgroundColor
 class ExtensionActionGetBadgeBackgroundColorFunction
     : public ExtensionActionFunction {
  protected:
-  virtual ~ExtensionActionGetBadgeBackgroundColorFunction() {}
-  virtual bool RunExtensionAction() override;
+  ~ExtensionActionGetBadgeBackgroundColorFunction() override {}
+  bool RunExtensionAction() override;
 };
 
 //
 // browserAction.* aliases for supported browserAction APIs.
 //
 
 class BrowserActionSetIconFunction : public ExtensionActionSetIconFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("browserAction.setIcon", BROWSERACTION_SETICON)
 
  protected:
-  virtual ~BrowserActionSetIconFunction() {}
+  ~BrowserActionSetIconFunction() override {}
 };
 
 class BrowserActionSetTitleFunction : public ExtensionActionSetTitleFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("browserAction.setTitle", BROWSERACTION_SETTITLE)
 
  protected:
-  virtual ~BrowserActionSetTitleFunction() {}
+  ~BrowserActionSetTitleFunction() override {}
 };
 
 class BrowserActionSetPopupFunction : public ExtensionActionSetPopupFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("browserAction.setPopup", BROWSERACTION_SETPOPUP)
 
  protected:
-  virtual ~BrowserActionSetPopupFunction() {}
+  ~BrowserActionSetPopupFunction() override {}
 };
 
 class BrowserActionGetTitleFunction : public ExtensionActionGetTitleFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("browserAction.getTitle", BROWSERACTION_GETTITLE)
 
  protected:
-  virtual ~BrowserActionGetTitleFunction() {}
+  ~BrowserActionGetTitleFunction() override {}
 };
 
 class BrowserActionGetPopupFunction : public ExtensionActionGetPopupFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("browserAction.getPopup", BROWSERACTION_GETPOPUP)
 
  protected:
-  virtual ~BrowserActionGetPopupFunction() {}
+  ~BrowserActionGetPopupFunction() override {}
 };
 
 class BrowserActionSetBadgeTextFunction
     : public ExtensionActionSetBadgeTextFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("browserAction.setBadgeText",
                              BROWSERACTION_SETBADGETEXT)
 
  protected:
-  virtual ~BrowserActionSetBadgeTextFunction() {}
+  ~BrowserActionSetBadgeTextFunction() override {}
 };
 
 class BrowserActionSetBadgeBackgroundColorFunction
     : public ExtensionActionSetBadgeBackgroundColorFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("browserAction.setBadgeBackgroundColor",
                              BROWSERACTION_SETBADGEBACKGROUNDCOLOR)
 
  protected:
-  virtual ~BrowserActionSetBadgeBackgroundColorFunction() {}
+  ~BrowserActionSetBadgeBackgroundColorFunction() override {}
 };
 
 class BrowserActionGetBadgeTextFunction
     : public ExtensionActionGetBadgeTextFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("browserAction.getBadgeText",
                              BROWSERACTION_GETBADGETEXT)
 
  protected:
-  virtual ~BrowserActionGetBadgeTextFunction() {}
+  ~BrowserActionGetBadgeTextFunction() override {}
 };
 
 class BrowserActionGetBadgeBackgroundColorFunction
     : public ExtensionActionGetBadgeBackgroundColorFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("browserAction.getBadgeBackgroundColor",
                              BROWSERACTION_GETBADGEBACKGROUNDCOLOR)
 
  protected:
-  virtual ~BrowserActionGetBadgeBackgroundColorFunction() {}
+  ~BrowserActionGetBadgeBackgroundColorFunction() override {}
 };
 
 class BrowserActionEnableFunction : public ExtensionActionShowFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("browserAction.enable", BROWSERACTION_ENABLE)
 
  protected:
-  virtual ~BrowserActionEnableFunction() {}
+  ~BrowserActionEnableFunction() override {}
 };
 
 class BrowserActionDisableFunction : public ExtensionActionHideFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("browserAction.disable", BROWSERACTION_DISABLE)
 
  protected:
-  virtual ~BrowserActionDisableFunction() {}
+  ~BrowserActionDisableFunction() override {}
 };
 
 class BrowserActionOpenPopupFunction : public ChromeAsyncExtensionFunction,
                                        public content::NotificationObserver {
  public:
   DECLARE_EXTENSION_FUNCTION("browserAction.openPopup",
                              BROWSERACTION_OPEN_POPUP)
   BrowserActionOpenPopupFunction();
 
  private:
-  virtual ~BrowserActionOpenPopupFunction() {}
+  ~BrowserActionOpenPopupFunction() override {}
 
   // ExtensionFunction:
-  virtual bool RunAsync() override;
+  bool RunAsync() override;
 
-  virtual void Observe(int type,
-                       const content::NotificationSource& source,
-                       const content::NotificationDetails& details) override;
+  void Observe(int type,
+               const content::NotificationSource& source,
+               const content::NotificationDetails& details) override;
   void OpenPopupTimedOut();
 
   content::NotificationRegistrar registrar_;
   bool response_sent_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserActionOpenPopupFunction);
 };
 
 }  // namespace extensions
 
 //
 // pageAction.* aliases for supported pageAction APIs.
 //
 
 class PageActionShowFunction : public extensions::ExtensionActionShowFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("pageAction.show", PAGEACTION_SHOW)
 
  protected:
-  virtual ~PageActionShowFunction() {}
+  ~PageActionShowFunction() override {}
 };
 
 class PageActionHideFunction : public extensions::ExtensionActionHideFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("pageAction.hide", PAGEACTION_HIDE)
 
  protected:
-  virtual ~PageActionHideFunction() {}
+  ~PageActionHideFunction() override {}
 };
 
 class PageActionSetIconFunction
     : public extensions::ExtensionActionSetIconFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("pageAction.setIcon", PAGEACTION_SETICON)
 
  protected:
-  virtual ~PageActionSetIconFunction() {}
+  ~PageActionSetIconFunction() override {}
 };
 
 class PageActionSetTitleFunction
     : public extensions::ExtensionActionSetTitleFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("pageAction.setTitle", PAGEACTION_SETTITLE)
 
  protected:
-  virtual ~PageActionSetTitleFunction() {}
+  ~PageActionSetTitleFunction() override {}
 };
 
 class PageActionSetPopupFunction
     : public extensions::ExtensionActionSetPopupFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("pageAction.setPopup", PAGEACTION_SETPOPUP)
 
  protected:
-  virtual ~PageActionSetPopupFunction() {}
+  ~PageActionSetPopupFunction() override {}
 };
 
 class PageActionGetTitleFunction
     : public extensions::ExtensionActionGetTitleFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("pageAction.getTitle", PAGEACTION_GETTITLE)
 
  protected:
-  virtual ~PageActionGetTitleFunction() {}
+  ~PageActionGetTitleFunction() override {}
 };
 
 class PageActionGetPopupFunction
     : public extensions::ExtensionActionGetPopupFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("pageAction.getPopup", PAGEACTION_GETPOPUP)
 
  protected:
-  virtual ~PageActionGetPopupFunction() {}
+  ~PageActionGetPopupFunction() override {}
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_ACTION_API_H_