Standardize usage of virtual/override/final in chrome/browser/extensions/

chrome/browser/extensions/api/declarative_content/content_action.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/declarative_content/content_action.h"
 
 #include <map>
 
 #include "base/lazy_instance.h"
 #include "base/strings/stringprintf.h"
@@ skipping 56 matching lines @@
       bool* bad_message) {
     // We can't show a page action if the extension doesn't have one.
     if (ActionInfo::GetPageActionInfo(extension) == NULL) {
       *error = kNoPageAction;
       return scoped_refptr<ContentAction>();
     }
     return scoped_refptr<ContentAction>(new ShowPageAction);
   }
 
   // Implementation of ContentAction:
-  virtual Type GetType() const override { return ACTION_SHOW_PAGE_ACTION; }
-  virtual void Apply(const std::string& extension_id,
-                     const base::Time& extension_install_time,
-                     ApplyInfo* apply_info) const override {
+  Type GetType() const override { return ACTION_SHOW_PAGE_ACTION; }
+  void Apply(const std::string& extension_id,
+             const base::Time& extension_install_time,
+             ApplyInfo* apply_info) const override {
     ExtensionAction* action =
         GetPageAction(apply_info->browser_context, extension_id);
     action->DeclarativeShow(ExtensionTabUtil::GetTabId(apply_info->tab));
     ExtensionActionAPI::Get(apply_info->browser_context)->NotifyChange(
         action, apply_info->tab, apply_info->browser_context);
   }
   // The page action is already showing, so nothing needs to be done here.
-  virtual void Reapply(const std::string& extension_id,
-                       const base::Time& extension_install_time,
-                       ApplyInfo* apply_info) const override {}
-  virtual void Revert(const std::string& extension_id,
-                      const base::Time& extension_install_time,
-                      ApplyInfo* apply_info) const override {
+  void Reapply(const std::string& extension_id,
+               const base::Time& extension_install_time,
+               ApplyInfo* apply_info) const override {}
+  void Revert(const std::string& extension_id,
+              const base::Time& extension_install_time,
+              ApplyInfo* apply_info) const override {
     if (ExtensionAction* action =
             GetPageAction(apply_info->browser_context, extension_id)) {
       action->UndoDeclarativeShow(ExtensionTabUtil::GetTabId(apply_info->tab));
       ExtensionActionAPI::Get(apply_info->browser_context)->NotifyChange(
           action, apply_info->tab, apply_info->browser_context);
     }
   }
 
  private:
   static ExtensionAction* GetPageAction(
       content::BrowserContext* browser_context,
       const std::string& extension_id) {
     const Extension* extension =
         ExtensionRegistry::Get(browser_context)
             ->GetExtensionById(extension_id, ExtensionRegistry::EVERYTHING);
     if (!extension)
       return NULL;
     return ExtensionActionManager::Get(browser_context)
         ->GetPageAction(*extension);
   }
-  virtual ~ShowPageAction() {}
+  ~ShowPageAction() override {}
 
   DISALLOW_COPY_AND_ASSIGN(ShowPageAction);
 };
 
 // Action that sets an extension's action icon.
 class SetIcon : public ContentAction {
  public:
   SetIcon(const gfx::Image& icon, ActionInfo::Type action_type)
       : icon_(icon), action_type_(action_type) {}
 
   static scoped_refptr<ContentAction> Create(
       content::BrowserContext* browser_context,
       const Extension* extension,
       const base::DictionaryValue* dict,
       std::string* error,
       bool* bad_message);
 
   // Implementation of ContentAction:
-  virtual Type GetType() const override { return ACTION_SET_ICON; }
-  virtual void Apply(const std::string& extension_id,
-                     const base::Time& extension_install_time,
-                     ApplyInfo* apply_info) const override {
+  Type GetType() const override { return ACTION_SET_ICON; }
+  void Apply(const std::string& extension_id,
+             const base::Time& extension_install_time,
+             ApplyInfo* apply_info) const override {
     Profile* profile = Profile::FromBrowserContext(apply_info->browser_context);
     ExtensionAction* action = GetExtensionAction(profile, extension_id);
     if (action) {
       action->DeclarativeSetIcon(ExtensionTabUtil::GetTabId(apply_info->tab),
                                  apply_info->priority,
                                  icon_);
       ExtensionActionAPI::Get(profile)
           ->NotifyChange(action, apply_info->tab, profile);
     }
   }
 
-  virtual void Reapply(const std::string& extension_id,
-                       const base::Time& extension_install_time,
-                       ApplyInfo* apply_info) const override {}
+  void Reapply(const std::string& extension_id,
+               const base::Time& extension_install_time,
+               ApplyInfo* apply_info) const override {}
 
-  virtual void Revert(const std::string& extension_id,
-                      const base::Time& extension_install_time,
-                      ApplyInfo* apply_info) const override {
+  void Revert(const std::string& extension_id,
+              const base::Time& extension_install_time,
+              ApplyInfo* apply_info) const override {
     Profile* profile = Profile::FromBrowserContext(apply_info->browser_context);
     ExtensionAction* action = GetExtensionAction(profile, extension_id);
     if (action) {
       action->UndoDeclarativeSetIcon(
           ExtensionTabUtil::GetTabId(apply_info->tab),
           apply_info->priority,
           icon_);
       ExtensionActionAPI::Get(apply_info->browser_context)
           ->NotifyChange(action, apply_info->tab, profile);
     }
@@ skipping 11 matching lines @@
       case ActionInfo::TYPE_BROWSER:
         return ExtensionActionManager::Get(profile)
             ->GetBrowserAction(*extension);
       case ActionInfo::TYPE_PAGE:
         return ExtensionActionManager::Get(profile)->GetPageAction(*extension);
       default:
         NOTREACHED();
     }
     return NULL;
   }
-  virtual ~SetIcon() {}
+  ~SetIcon() override {}
 
   gfx::Image icon_;
   ActionInfo::Type action_type_;
 
   DISALLOW_COPY_AND_ASSIGN(SetIcon);
 };
 
 // Helper for getting JS collections into C++.
 static bool AppendJSStringsToCPPStrings(const base::ListValue& append_strings,
                                         std::vector<std::string>* append_to) {
@@ skipping 298 matching lines @@
                              bool* bad_message,
                              const base::DictionaryValue** action_dict,
                              std::string* instance_type) {
   INPUT_FORMAT_VALIDATE(json_action.GetAsDictionary(action_dict));
   INPUT_FORMAT_VALIDATE(
       (*action_dict)->GetString(keys::kInstanceType, instance_type));
   return true;
 }
 
 }  // namespace extensions