Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 666143003: Remove includes of RenderSVGResource.h where it's not used (Closed)

Created:
6 years, 2 months ago by fs
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, pdr+svgwatchlist_chromium.org, rune+blink
Project:
blink
Visibility:
Public.

Description

Remove includes of RenderSVGResource.h where it's not used Some additional unused includes nearby also bite the dust. BUG=420022 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M Source/core/paint/SVGInlineTextBoxPainter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMasker.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGText.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderingContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGGElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGGElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTextElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
This has a trivial conflict with https://codereview.chromium.org/658333003/ (both remove the SolidColor include from SVGInlineTextBox.cpp)
6 years, 2 months ago (2014-10-21 13:48:21 UTC) #2
Stephen Chennney
lgtm
6 years, 2 months ago (2014-10-21 13:54:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666143003/1
6 years, 2 months ago (2014-10-21 13:55:29 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 14:48:24 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184091

Powered by Google App Engine
This is Rietveld 408576698