Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3206)

Unified Diff: chrome/browser/sync_file_system/drive_backend/sync_worker.h

Issue 666143002: Standardize usage of virtual/override/final in chrome/browser/sync_file_system/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync_file_system/drive_backend/sync_worker.h
diff --git a/chrome/browser/sync_file_system/drive_backend/sync_worker.h b/chrome/browser/sync_file_system/drive_backend/sync_worker.h
index 1461ca38dd5321daf7f9a06279dc4ab269220785..1cf701ce7cedf9c5e8751f06662c90d104ba4569 100644
--- a/chrome/browser/sync_file_system/drive_backend/sync_worker.h
+++ b/chrome/browser/sync_file_system/drive_backend/sync_worker.h
@@ -58,47 +58,46 @@ class SyncWorker : public SyncWorkerInterface,
const base::WeakPtr<ExtensionServiceInterface>& extension_service,
leveldb::Env* env_override);
- virtual ~SyncWorker();
+ ~SyncWorker() override;
- virtual void Initialize(scoped_ptr<SyncEngineContext> context) override;
+ void Initialize(scoped_ptr<SyncEngineContext> context) override;
// SyncTaskManager::Client overrides
- virtual void MaybeScheduleNextTask() override;
- virtual void NotifyLastOperationStatus(
- SyncStatusCode sync_status, bool used_network) override;
- virtual void RecordTaskLog(scoped_ptr<TaskLogger::TaskLog> task_log) override;
+ void MaybeScheduleNextTask() override;
+ void NotifyLastOperationStatus(SyncStatusCode sync_status,
+ bool used_network) override;
+ void RecordTaskLog(scoped_ptr<TaskLogger::TaskLog> task_log) override;
// SyncWorkerInterface overrides
- virtual void RegisterOrigin(const GURL& origin,
- const SyncStatusCallback& callback) override;
- virtual void EnableOrigin(const GURL& origin,
- const SyncStatusCallback& callback) override;
- virtual void DisableOrigin(const GURL& origin,
- const SyncStatusCallback& callback) override;
- virtual void UninstallOrigin(const GURL& origin,
- RemoteFileSyncService::UninstallFlag flag,
- const SyncStatusCallback& callback) override;
- virtual void ProcessRemoteChange(const SyncFileCallback& callback) override;
- virtual void SetRemoteChangeProcessor(
- RemoteChangeProcessorOnWorker* remote_change_processor_on_worker)
- override;
- virtual RemoteServiceState GetCurrentState() const override;
- virtual void GetOriginStatusMap(
+ void RegisterOrigin(const GURL& origin,
+ const SyncStatusCallback& callback) override;
+ void EnableOrigin(const GURL& origin,
+ const SyncStatusCallback& callback) override;
+ void DisableOrigin(const GURL& origin,
+ const SyncStatusCallback& callback) override;
+ void UninstallOrigin(const GURL& origin,
+ RemoteFileSyncService::UninstallFlag flag,
+ const SyncStatusCallback& callback) override;
+ void ProcessRemoteChange(const SyncFileCallback& callback) override;
+ void SetRemoteChangeProcessor(RemoteChangeProcessorOnWorker*
+ remote_change_processor_on_worker) override;
+ RemoteServiceState GetCurrentState() const override;
+ void GetOriginStatusMap(
const RemoteFileSyncService::StatusMapCallback& callback) override;
- virtual scoped_ptr<base::ListValue> DumpFiles(const GURL& origin) override;
- virtual scoped_ptr<base::ListValue> DumpDatabase() override;
- virtual void SetSyncEnabled(bool enabled) override;
- virtual void PromoteDemotedChanges(const base::Closure& callback) override;
- virtual void ApplyLocalChange(const FileChange& local_change,
- const base::FilePath& local_path,
- const SyncFileMetadata& local_metadata,
- const storage::FileSystemURL& url,
- const SyncStatusCallback& callback) override;
- virtual void ActivateService(RemoteServiceState service_state,
- const std::string& description) override;
- virtual void DeactivateService(const std::string& description) override;
- virtual void DetachFromSequence() override;
- virtual void AddObserver(Observer* observer) override;
+ scoped_ptr<base::ListValue> DumpFiles(const GURL& origin) override;
+ scoped_ptr<base::ListValue> DumpDatabase() override;
+ void SetSyncEnabled(bool enabled) override;
+ void PromoteDemotedChanges(const base::Closure& callback) override;
+ void ApplyLocalChange(const FileChange& local_change,
+ const base::FilePath& local_path,
+ const SyncFileMetadata& local_metadata,
+ const storage::FileSystemURL& url,
+ const SyncStatusCallback& callback) override;
+ void ActivateService(RemoteServiceState service_state,
+ const std::string& description) override;
+ void DeactivateService(const std::string& description) override;
+ void DetachFromSequence() override;
+ void AddObserver(Observer* observer) override;
private:
friend class DriveBackendSyncTest;

Powered by Google App Engine
This is Rietveld 408576698