Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Unified Diff: chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc

Issue 666143002: Standardize usage of virtual/override/final in chrome/browser/sync_file_system/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc
diff --git a/chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc b/chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc
index c62c12aa973d4cafa3b51f796951e50ba4ae8987..cd24f6ec2a547072260b202c3ec6471c9a80c86d 100644
--- a/chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc
+++ b/chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc
@@ -67,19 +67,16 @@ class TaskManagerClient
base::MessageLoop::current()->RunUntilIdle();
maybe_schedule_next_task_count_ = 0;
}
- virtual ~TaskManagerClient() {}
+ ~TaskManagerClient() override {}
// DriveFileSyncManager::Client overrides.
- virtual void MaybeScheduleNextTask() override {
- ++maybe_schedule_next_task_count_;
- }
- virtual void NotifyLastOperationStatus(
- SyncStatusCode last_operation_status,
- bool last_operation_used_network) override {
+ void MaybeScheduleNextTask() override { ++maybe_schedule_next_task_count_; }
+ void NotifyLastOperationStatus(SyncStatusCode last_operation_status,
+ bool last_operation_used_network) override {
last_operation_status_ = last_operation_status;
}
- virtual void RecordTaskLog(scoped_ptr<TaskLogger::TaskLog>) override {}
+ void RecordTaskLog(scoped_ptr<TaskLogger::TaskLog>) override {}
void ScheduleTask(SyncStatusCode status_to_return,
const SyncStatusCallback& callback) {
@@ -141,9 +138,9 @@ class MultihopSyncTask : public ExclusiveTask {
DCHECK(task_completed_);
}
- virtual ~MultihopSyncTask() {}
+ ~MultihopSyncTask() override {}
- virtual void RunExclusive(const SyncStatusCallback& callback) override {
+ void RunExclusive(const SyncStatusCallback& callback) override {
DCHECK(!*task_started_);
*task_started_ = true;
base::MessageLoop::current()->PostTask(
@@ -188,10 +185,9 @@ class BackgroundTask : public SyncTask {
weak_ptr_factory_(this) {
}
- virtual ~BackgroundTask() {
- }
+ ~BackgroundTask() override {}
- virtual void RunPreflight(scoped_ptr<SyncTaskToken> token) override {
+ void RunPreflight(scoped_ptr<SyncTaskToken> token) override {
scoped_ptr<TaskBlocker> task_blocker(new TaskBlocker);
task_blocker->app_id = app_id_;
task_blocker->paths.push_back(path_);
@@ -245,10 +241,9 @@ class BlockerUpdateTestHelper : public SyncTask {
weak_ptr_factory_(this) {
}
- virtual ~BlockerUpdateTestHelper() {
- }
+ ~BlockerUpdateTestHelper() override {}
- virtual void RunPreflight(scoped_ptr<SyncTaskToken> token) override {
+ void RunPreflight(scoped_ptr<SyncTaskToken> token) override {
UpdateBlocker(token.Pass());
}

Powered by Google App Engine
This is Rietveld 408576698