Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: components/web_modal/web_contents_modal_dialog_manager.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/web_modal/web_contents_modal_dialog_manager.h
diff --git a/components/web_modal/web_contents_modal_dialog_manager.h b/components/web_modal/web_contents_modal_dialog_manager.h
index 4817753fc02fac8f5802d91a8f07d6e3ad806f7f..eb0dd124b7de1eeb4da2e550ea9508770edd5da6 100644
--- a/components/web_modal/web_contents_modal_dialog_manager.h
+++ b/components/web_modal/web_contents_modal_dialog_manager.h
@@ -23,7 +23,7 @@ class WebContentsModalDialogManager
public content::WebContentsObserver,
public content::WebContentsUserData<WebContentsModalDialogManager> {
public:
- virtual ~WebContentsModalDialogManager();
+ ~WebContentsModalDialogManager() override;
WebContentsModalDialogManagerDelegate* delegate() const { return delegate_; }
void SetDelegate(WebContentsModalDialogManagerDelegate* d);
@@ -50,8 +50,8 @@ class WebContentsModalDialogManager
void FocusTopmostDialog() const;
// SingleWebContentsDialogManagerDelegate:
- virtual content::WebContents* GetWebContents() const override;
- virtual void WillClose(NativeWebContentsModalDialog dialog) override;
+ content::WebContents* GetWebContents() const override;
+ void WillClose(NativeWebContentsModalDialog dialog) override;
// For testing.
class TestApi {
@@ -99,14 +99,14 @@ class WebContentsModalDialogManager
void CloseAllDialogs();
// Overridden from content::WebContentsObserver:
- virtual void DidNavigateMainFrame(
+ void DidNavigateMainFrame(
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params) override;
- virtual void DidGetIgnoredUIEvent() override;
- virtual void WasShown() override;
- virtual void WasHidden() override;
- virtual void WebContentsDestroyed() override;
- virtual void DidAttachInterstitialPage() override;
+ void DidGetIgnoredUIEvent() override;
+ void WasShown() override;
+ void WasHidden() override;
+ void WebContentsDestroyed() override;
+ void DidAttachInterstitialPage() override;
// Delegate for notifying our owner about stuff. Not owned by us.
WebContentsModalDialogManagerDelegate* delegate_;

Powered by Google App Engine
This is Rietveld 408576698