Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: components/variations/entropy_provider_unittest.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/variations/entropy_provider.h ('k') | components/variations/variations_http_header_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/variations/entropy_provider_unittest.cc
diff --git a/components/variations/entropy_provider_unittest.cc b/components/variations/entropy_provider_unittest.cc
index fd947050ac73aa95308855d0f431616e1b083278..652ab44e64b8a8f2d17bc4ced71fba748e64752f 100644
--- a/components/variations/entropy_provider_unittest.cc
+++ b/components/variations/entropy_provider_unittest.cc
@@ -80,10 +80,9 @@ class SHA1EntropyGenerator : public TrialEntropyGenerator {
: trial_name_(trial_name) {
}
- virtual ~SHA1EntropyGenerator() {
- }
+ ~SHA1EntropyGenerator() override {}
- virtual double GenerateEntropyValue() const override {
+ double GenerateEntropyValue() const override {
// Use a random GUID + 13 additional bits of entropy to match how the
// SHA1EntropyProvider is used in metrics_service.cc.
const int low_entropy_source =
@@ -113,10 +112,9 @@ class PermutedEntropyGenerator : public TrialEntropyGenerator {
&mapping_);
}
- virtual ~PermutedEntropyGenerator() {
- }
+ ~PermutedEntropyGenerator() override {}
- virtual double GenerateEntropyValue() const override {
+ double GenerateEntropyValue() const override {
const int low_entropy_source =
static_cast<uint16>(base::RandInt(0, kMaxLowEntropySize - 1));
return mapping_[low_entropy_source] /
« no previous file with comments | « components/variations/entropy_provider.h ('k') | components/variations/variations_http_header_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698