components/translate/core/browser/translate_infobar_delegate.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/browser/translate_infobar_delegate.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/translate/core/browser/options_menu_model.h ('k') | components/translate/core/browser/translate_url_fetcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/core/browser/translate_infobar_delegate.h

diff --git a/components/translate/core/browser/translate_infobar_delegate.h b/components/translate/core/browser/translate_infobar_delegate.h

index 28365cbbd9c6c8b44bb209f596599554698308bc..f0ca7695db7db0b46f09b28010b487b9b8f6a89a 100644

--- a/components/translate/core/browser/translate_infobar_delegate.h

+++ b/components/translate/core/browser/translate_infobar_delegate.h

@@ -40,7 +40,7 @@ class TranslateInfoBarDelegate : public infobars::InfoBarDelegate {

static const size_t kNoIndex;

- virtual ~TranslateInfoBarDelegate();

+ ~TranslateInfoBarDelegate() override;

// Factory method to create a translate infobar. |error_type| must be

// specified iff |step| == TRANSLATION_ERROR. For other translate steps,

@@ -192,11 +192,11 @@ class TranslateInfoBarDelegate : public infobars::InfoBarDelegate {

typedef std::pair<std::string, base::string16> LanguageNamePair;

// InfoBarDelegate:

- virtual void InfoBarDismissed() override;

- virtual int GetIconID() const override;

- virtual infobars::InfoBarDelegate::Type GetInfoBarType() const override;

- virtual bool ShouldExpire(const NavigationDetails& details) const override;

- virtual TranslateInfoBarDelegate* AsTranslateInfoBarDelegate() override;

+ void InfoBarDismissed() override;

+ int GetIconID() const override;

+ infobars::InfoBarDelegate::Type GetInfoBarType() const override;

+ bool ShouldExpire(const NavigationDetails& details) const override;

+ TranslateInfoBarDelegate* AsTranslateInfoBarDelegate() override;

bool is_off_the_record_;

translate::TranslateStep step_;