components/translate/content/renderer/translate_helper.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/content/renderer/translate_helper.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/translate/content/renderer/static_renderer_cld_data_provider.h ('k') | components/translate/core/browser/language_state_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/content/renderer/translate_helper.h

diff --git a/components/translate/content/renderer/translate_helper.h b/components/translate/content/renderer/translate_helper.h

index 6e12c69dede4f3b52f4d32c1825614502bd37a66..4d9275d97860625efd0b66e12b0df357d5900536 100644

--- a/components/translate/content/renderer/translate_helper.h

+++ b/components/translate/content/renderer/translate_helper.h

@@ -83,7 +83,7 @@ class TranslateHelper : public content::RenderViewObserver {

int world_id,

int extension_group,

const std::string& extension_scheme);

- virtual ~TranslateHelper();

+ ~TranslateHelper() override;

// Informs us that the page's text has been extracted.

void PageCaptured(const base::string16& contents);

@@ -180,7 +180,7 @@ class TranslateHelper : public content::RenderViewObserver {

static bool IsTranslationAllowed(blink::WebDocument* document);

// RenderViewObserver implementation.

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ bool OnMessageReceived(const IPC::Message& message) override;

// Informs us that the page's text has been extracted.

void PageCapturedImpl(int page_seq_no, const base::string16& contents);