Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: components/translate/content/browser/content_translate_driver.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/content/browser/content_translate_driver.h
diff --git a/components/translate/content/browser/content_translate_driver.h b/components/translate/content/browser/content_translate_driver.h
index 196ebaf18564858482df3d3b6dac33839fbeb0c6..4acb00d3d5fc7907c0525def4f0c91980b7068b2 100644
--- a/components/translate/content/browser/content_translate_driver.h
+++ b/components/translate/content/browser/content_translate_driver.h
@@ -51,7 +51,7 @@ class ContentTranslateDriver : public TranslateDriver,
};
ContentTranslateDriver(content::NavigationController* nav_controller);
- virtual ~ContentTranslateDriver();
+ ~ContentTranslateDriver() override;
// Adds or Removes observers.
void AddObserver(Observer* observer);
@@ -71,30 +71,29 @@ class ContentTranslateDriver : public TranslateDriver,
void InitiateTranslation(const std::string& page_lang, int attempt);
// TranslateDriver methods.
- virtual void OnIsPageTranslatedChanged() override;
- virtual void OnTranslateEnabledChanged() override;
- virtual bool IsLinkNavigation() override;
- virtual void TranslatePage(int page_seq_no,
- const std::string& translate_script,
- const std::string& source_lang,
- const std::string& target_lang) override;
- virtual void RevertTranslation(int page_seq_no) override;
- virtual bool IsOffTheRecord() override;
- virtual const std::string& GetContentsMimeType() override;
- virtual const GURL& GetLastCommittedURL() override;
- virtual const GURL& GetActiveURL() override;
- virtual const GURL& GetVisibleURL() override;
- virtual bool HasCurrentPage() override;
- virtual void OpenUrlInNewTab(const GURL& url) override;
+ void OnIsPageTranslatedChanged() override;
+ void OnTranslateEnabledChanged() override;
+ bool IsLinkNavigation() override;
+ void TranslatePage(int page_seq_no,
+ const std::string& translate_script,
+ const std::string& source_lang,
+ const std::string& target_lang) override;
+ void RevertTranslation(int page_seq_no) override;
+ bool IsOffTheRecord() override;
+ const std::string& GetContentsMimeType() override;
+ const GURL& GetLastCommittedURL() override;
+ const GURL& GetActiveURL() override;
+ const GURL& GetVisibleURL() override;
+ bool HasCurrentPage() override;
+ void OpenUrlInNewTab(const GURL& url) override;
// content::WebContentsObserver implementation.
- virtual void NavigationEntryCommitted(
+ void NavigationEntryCommitted(
const content::LoadCommittedDetails& load_details) override;
- virtual void DidNavigateAnyFrame(
- content::RenderFrameHost* render_frame_host,
- const content::LoadCommittedDetails& details,
- const content::FrameNavigateParams& params) override;
- virtual bool OnMessageReceived(const IPC::Message& message) override;
+ void DidNavigateAnyFrame(content::RenderFrameHost* render_frame_host,
+ const content::LoadCommittedDetails& details,
+ const content::FrameNavigateParams& params) override;
+ bool OnMessageReceived(const IPC::Message& message) override;
// IPC handlers.
void OnTranslateAssignedSequenceNumber(int page_seq_no);

Powered by Google App Engine
This is Rietveld 408576698